search

libretro / libretro-thumbnails

Boxarts, titlescreen, and in-game screenshots for the no-intro DATs used by RetroArch
350 stars 350 forks source link

cross-platform /no-intro standard naming for thumbnail filenames #143

Closed markwkidd closed 7 years ago

markwkidd commented 8 years ago

I have been running into trouble cloning the thumbnail repo to a Windows machine, and I believe the problem lies with some thumbnails who do not have properly escaped filenames. In particular, my machine is not handling some : colons that didn't get escaped into _ underscores.

Unfortunately due to the way git is working, or maybe my lack of skill with it, I am having trouble creating a PR to rename the files. Maybe @RobLoach or another thumbnail guru could take a look?

I'm pasting the filenames below, but I also noticed that if I enter the : colon character in github's "find file" feature, it turns up another two pages of thumbnails which don't have their colons escaped into an _ underscore.

libretro-thumbnails/FB Alpha - Arcade Games/Named_Titles/E.D.F. : Earth Defense Force.png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Snaps/E.D.F. : Earth Defense Force.png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Titles/E.D.F. : Earth Defense Force.png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Snaps/E.D.F. : Earth Defense Force (North America).png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Titles/E.D.F. : Earth Defense Force (North America).png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Snaps/E.D.F. : Earth Defense Force (bootleg) [Bootleg, no sound].png 
libretro-thumbnails/FB Alpha - Arcade Games/Named_Titles/E.D.F. : Earth Defense Force (bootleg) [Bootleg, no sound].png
markwkidd commented 8 years ago

Edit: there are too many files with prohibited characters to try to list them all!

markwkidd commented 7 years ago

The more I look into this, the more illegal characters I'm finding throughout the thumbnail repository. I hopped to a different operating system and spent some trying to figure out what's what with this issue.

I have created a PR which I think resolves most of the prohibited character situation: https://github.com/libretro/libretro-thumbnails/pull/144

markwkidd commented 7 years ago

Closing this in favor of the PR