libretro / libretro-uae

PUAE libretro
GNU General Public License v2.0
114 stars 61 forks source link

One of two commits severely impacts performance on recent builds #511

Closed rhester72 closed 2 years ago

rhester72 commented 2 years ago

Somewhere between 28-Mar-2022 and 7-Apr-2022, a commit SEVERELY impaired performance (even on an overclocked RPi 4) and more than doubled the binary size.

I suspect commit https://github.com/libretro/libretro-uae/commit/022c82b63ccb0d76a35803e52fa3458542f7ebf0 due to the apparent addition of esp.c but that is a guess on my part. Something definitely significantly changed, and from what I can tell nothing in the Retropie toolchain was updated in between.

zzedmore commented 2 years ago

Probably due to the fact that sonninos updated PUAE to v4.5.1 for more accuracy from WinUAE. The old build is now called puae2021.

sonninnos commented 2 years ago

Yes, the new 4.5.0 version is to blame. The old version is kept in 2.6.1 branch for the low-power machines. Accuracy comes at a cost. No way around it I'm afraid.

rhester72 commented 2 years ago

Understood, will ask the Retropie folks whether they can maintain both. Thank you!

ZzackKbin commented 2 years ago

You killing my dune. Now glitches with normal speed or normal graphics with glitches in audio on RPi4:(

sonninnos commented 2 years ago

It is what it is. Use the old core version.

ZzackKbin commented 2 years ago

how? retropie see only newest.

sonninnos commented 2 years ago

If puae2021 core is not yet available to download, you must build the 2.6.1 branch manually.

ZzackKbin commented 2 years ago

Is too much for me.

rhester72 commented 2 years ago

@ZzackKbin I've raised the question of tracking puae2021 as a separate package in RetroPie here:

https://retropie.org.uk/forum/topic/32502/can-retropie-please-track-legacy-lr-puae-now

For the time being, I'm attaching a build of 2.6.1 HEAD here, just replace your existing library with this and you'll be up to date (thus far).

puae_libretro.zip

(Unzip, copy to your RetroPie box, ssh in and copy it to /opt/retropie/libretrocores/lr-puae)

ZzackKbin commented 2 years ago

Thx :)

sonninnos commented 2 years ago

Enabling "Immediate Blitter" seems to also fix the graphic glitches without Cycle-exact.

ZzackKbin commented 2 years ago

Enabling "Immediate Blitter" seems to also fix the graphic glitches without Cycle-exact.

works. thx