search

libretro / libretro-uae

PUAE libretro
GNU General Public License v2.0
111 stars 60 forks source link

lr-puae2021 mouse jitter over time on interlaced screens fix #560

Closed rhester72 closed 1 year ago

rhester72 commented 1 year ago

I experienced the issue described here:

https://eab.abime.net/showthread.php?t=109446

and found the fix from early this year:

https://github.com/tonioni/WinUAE/commit/0027bcff91ce5a458c77c8cd8b8134f2d0a36240

which I've backported to lr-puae2021 in the attached patch (forgive me, I am not fluent enough in git to do it via pull request).

This does NOT apply to the newer lr-puae branch (with a much more modern WinUAE base) that already includes this patch.

I've tested with no issues and confirmed it resolves the issue, Please consider applying the patch to the lr-puae2021 branch for future releases.

inputdevice_mousefix.zip

sonninnos commented 1 year ago

Thanks, looking good. I'll try to do some tests as soon as possible.

rhester72 commented 1 year ago

Thank you!

The same issue was identified and corrected (by the same means) in Amiberry here, just for reference:

https://github.com/BlitterStudio/amiberry/issues/624

rhester72 commented 1 year ago

For testing, please note that what was described in the EAB thread is accurate - you see it after about 10 hours on an interlaced screen.

sonninnos commented 1 year ago

Heh, I don't have time to wait 10 hours, so I'll take your word for it. Patch applied and pushed.

rhester72 commented 1 year ago

Thanks much! Will provide final confirmation once the binary build updates propagate.

rhester72 commented 1 year ago

Never mind - compiled from latest source from RetroPie-Setup directly, let it run for 12 hours, and no issues - confirmed good. Huge thanks for the integration help!