Closed Wilstorm closed 5 years ago
Wilstorm
commented
5 years ago Here's a screenshot from commit b0142d7 with the vector resolution multiplier set to 4 when it was working correctly. One of the commits @markwkidd did from 2/8/19 or newer seems to have broken the vector setting.
markwkidd
commented
5 years ago That seems like a good theory. I'll look for the issue there first.
On Thu, Apr 4, 2019, 12:03 PM Wilstorm notifications@github.com wrote:
Here's a screenshot from commit b0142d7 https://github.com/libretro/mame2003-libretro/commit/b0142d797cf5caebd2d012acb6fa811de3b0eeb3 with the vector resolution multiplier set to 4 when it was working correctly. One of the commits @markwkidd https://github.com/markwkidd did from 2/8/19 or newer seems to have broken the vector setting.
[image: llander-190404-115657] https://user-images.githubusercontent.com/8192258/55574169-668a3d00-56d1-11e9-843a-487486418862.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-libretro/issues/437#issuecomment-479981829, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdsDiQL3wX3QsYJY-Mn66BsaxXhW8ks5vdjBpgaJpZM4cbHcy .
Wilstorm
commented
5 years ago @markwkidd - Thanks, I figure it had to be one of the commits you did since you're the only one doing them but after I wrote that I thought it might be a combination of something else too. Computers, you just never know. :)
I tried it on a few cards and all of the current images I am running are doing it. It seems the vector multiplier is set to some default that you can't change or it doesn't seem to honor any value but the default. m3plus is working fine.
ghost
commented
5 years ago nice to see people still test the updates nice find pull request is in to fix it
Wilstorm
commented
5 years ago @grant2258 - Thanks a bunch for the update and fixing the issue. I mainly use m3plus but leave 2003 loaded for comparison or to test games if something isn't working in m3plus. I really appreciate it. If you need me to test anything just let me know.
ghost
commented
5 years ago Ill let you know if i need anything tested cheers. Im not really doing much more i think the only fixes ill be doing is bug fixes and always on the hunt for new games to be added to plus. I will be adding lr and rt support to plus just waiting for mark to do some none legacy updates he is going to do first before adding it.
Wilstorm
commented
5 years ago @grant2258 - Thanks for everything. I was wondering would it be possible to add 810x1080 to the vector resolution options?
What I've been doing is using 1440x1080 for 4:3 games and it seems to work great of HD displays. It's a natural fit for Core Provided resolutions. I was hoping it would do the same for 3:4 games by adding 810x1080 for games like Tempest, etc.
I've been following all the work you guys do on Plus for over a year now and when you guys kind of hit a good spot with the core I just haven't been doing as much either. I just kind of ground to a halt this past month or so. I'll keep an eye out if you guys do another project as it was interesting and I learned several new things that are incredibly helpful in working with the core and RA. I really appreciate what you guys did with m3plus. It's an incredibly fun core! :)
ghost
commented
5 years ago The problems with this game is its rotated if you put tate mode on youll see it how it should look. At saying that if you have artwork for me to test ill test with 1080x810 and 810x1080 and take screen shots and see if its what you want before adding it as a pull request
Wilstorm
commented
5 years ago @grant2258 - Ah ok, yeah I don't have any artwork or anything. For games like Lunar Lander on an HD display (1920x1080) I pick 1440x1080 which looks decent with that as a default out of the box for all 4:3 games. Then I apply bi-linear filtering just to smooth it out a bit and it looks perfect.
I find my 4k TV makes the beams look a bit wide and a bit rough so I go with a width of 1 but on a regular PC display I go with a beam width of 2 which looks perfect.
I was thinking that 810x1080 would make games like Tempest (3:4 games) look decent but if there's no benefit then I good with the current vector resolutions.
Basically I was trying to set one resolution with an .opt file for 4:3 games and another resolution for 3:4 games as a starting point. Then figure if there's any oddball vector games that would require something besides those two resolutions.
I definitely prefer bi-linear filtering on as it does add a touch of blur but just enough to give the lines a nice smooth look.
Wilstorm
commented
5 years ago @grant2258 - Thanks for fixing the resolution. Now they have the actual resolution vs the multiplier and everything seems to be working fine. I will close this issue out.
In Lunar Lander the vector resolution multiplier doesn't appear to be working properly. Here's a screenshot with it set to 4. If I set it to anywhere from 1 to 10 it appears to be the same regardless of the setting. I also posted the verbose log below too. I am running RetroPie 4.4.11 (on a Pi 3), Retroarch 1.7.6, ES 2.8.2 on commit 2961cbd.