libretro / mame2003-libretro

MAME 0.78 for libretro. Compatible with MAME 0.78 sets.
Other
90 stars 74 forks source link

Avoid multiple detect from single12way rotate #514

Closed zorro2055 closed 3 months ago

zorro2055 commented 3 months ago

Hi @mahoneyt944 ,

This is the same patch that I did for mame2003-plus, adding the "X-Way Joystick" option to the Analog Controls menu only for IPT_DIAL and IPT_DIAL_V devices. Enabling the X-Way Joystick option eliminates one rotary step of a X-Way rotary joystick from sometimes rotating the character 2 rotary steps.

This basically combines the codes used in these two PRs in mame2003-plus: https://github.com/libretro/mame2003-plus-libretro/pull/1652 https://github.com/libretro/mame2003-plus-libretro/pull/1740

It has been about two weeks since those PRs settled, and I didn't see anything mentioned in the issues list, so I assume no bugs have been discovered.

Also, question for you. Is there a good place to put recommended key/joy step, sensitivity, and x-way joystick settings for each of the 15ish or so games that used a x-way rotary joystick? I figured out what the specific settings that work best for each game with an x-way rotary joystick. I'd be interested to add that in a blog or faq somewhere so people know about it. I'd want to add that for mame2003 and mame2003-plus. If that is not possible, I do plan at the least to send that info to the manufacturer of the 12-way rotary joystick that I have.

Thanks!

Thank you wanting to make a contribution to this project!

Please note that by contributing code or other intellectual to this project you are allowing the project to make unlimited use of your contribution. As with the rest of the project, new contributions will be made available freely under the classic MAME Non-Commercial License.

This license can be viewed at https://raw.githubusercontent.com/libretro/mame2003-libretro/master/LICENSE.md.

mahoneyt944 commented 3 months ago

@zorro2055 well idk about noting it here, but you can in mame2003+'s CHANGELOG.md, just add an input section or at the bottom.

zorro2055 commented 3 months ago

Thanks @mahoneyt944 . I'll add that to CHANGELOG.md in a new PR as you suggest and will post it here for good measure.

zorro2055 commented 3 months ago

Posting description of X-Way Joystick option and recommended analog controls settings here for X-way rotary joystick games here for reference.