Closed ghost closed 6 years ago
we have reported the issue to the retropie time a few days ago
YEah, although this was caused by the needs of the libretro buildbot it unfortunately can't be fixed on our end for you. It needs to be fixed on the retropie end.
@markwkidd you think we could do a rule for the makefile for the retropie end for the target name?
Oh, I never saw any pull requests regarding this so I thought it might be one of the commits here that did it.
hold on ill get you the link
add a line on the buid.sh script to copy the newname to oldname will fix it in the meantime after the build of course cp mame2003_plus_libretro.so lr-mame2003-plus
Easier said than done ! I'll just have to wait for Buzz to fix it again. Why was the name changed ?
YEah, although this was caused by the needs of the libretro buildbot it unfortunately can't be fixed on our end for you. It needs to be fixed on the retropie end.
As I said, i'll have to wait for Buzz (joolswills) to fix it.
I am using RetroPie, so what file do I have to edit to get this to build ?
/home/pi/RetroPie-Setup/scriptmodules/libretrocores/
the scripts are in here
Sorry, I didn't make myself clear enough. I know where the scripts are. I wondered what do I have to add and to which script ? If I edit these scripts Retropie won't run it.
I ask because I have no idea when it's going to be updated by Retropie.
it will run it its what retropie uses i think jools want people to post on the forums to get the changes done from what i can see.
So any idea what I have to add to what script ? How is everyone else using the latest build ?
i think jools is fed up with pull requests for this he easiest way for you to fix this is edit makefile and change the targetname until retropie fix it
I do wonder if maybe he's not paying as much attention to messages from me these days.
Since there have been so many. Since I have inadvertently caused several RetroPie build errors lately. Hm.
I dont think he was ever particularly fond of this core anyway, maybe even less so now with all the extra work we are giving him :)
i think it just the updated to the new retropie as well might just be trying to find a solution to both old and new. I like to think the best of people though
if there was some sort of variable the showed we where using retropie we could make a rule in the makefile
he asked for us to raise an issue so we could keep him aware of upstream changes (such as the mame2003_plus/-plus change).
that issue is easily fixed in retropie, i think? they just have to change the name of the core within the scirpts to mame2003_plus, as it uses this name when looking for the binary.
yea agreed the fix is easy but its getting it accepted
i did update the info in an issue
that's what i'm saying - stuff like this, we don't need to raise a PR for it - just keep jools updated on the issues we're having (via an issue) and he'll update it in the way he would like. it's more hassle for him to read + review + suggest changes. that's what he asked us to do.
OK I see that there is no current/active issue at RetroPie-Setup in which to talk with jools about our build issue.
RetroPie/RetroPie-Setup#2374 (comment)
he is redoing the scripts when he gets to that he will probably do the update
Will you be updating here when we can update? I feel something's wrong as I haven't download from source for several days now. ;)
I can do a quick script hack for you to build when i get up just finished a shift so need catch some zzzs. I dont want anyone pushing this as a pull req on retropie if i do it though
I'd appreciate a script or something to build the latest. You never did say what I had to add to what script so I gave up asking :) I don't think RetroPie is in too much of a hurry, It's been over a week now :(
I agree if it's not to much work that would be great good sir! :) Do you guys know does Head On have sound in Plus?
Here's a handy site to use if you wanna know if a game has sound or not as per the MAME Wip click info to read it http://adb.arcadeitalia.net/dettaglio_mame.php?game_name=headon&arcade_only=0&autosearch=1&lang=en
@arcadez - That's really a neat site! A great amount of good information. So when it reads "Imperfect" could that also mean none? It seems the last time I played it did not have any audio. I have Irem stuck in my head and that you had worked on some games.
0.117u1: Couriersud added Discrete sound to Head On and clones, Space Attack / Head On, Head On 2 and Invinco / Head On 2 in the VIC Dual driver.
Any mame build before the above wont support sound for the Headon games, just play Counter Run intead it's a nice wee update to the series.
@arcadez - Thanks for the game tip. I know there's a whole slew of great games I've never even tried. I will give this a whirl tonight!
here is the fix for fix
type cd ~/RetroPie-Setup/
wget https://github.com/grant2258/mamemagic2003/raw/master/lr-mame2003-plus.sh sudo mv lr-mame2003-plus.sh scriptmodules/libretrocores/
compile as usual your good to go
Thank you good sir, much appreciated! :)
no problems at all
Quick question. I updated my RetroPie script. I ran the wget, moved the script but where it gets weird is when I go into the RetroPie menu to update I have two options that are identical except the line number. I'm not sure what to make of it. I redid the steps after the RetroPie script update but still the same.
231 lr-mame2003-plus
232 lr-mame2003-plus
@grant2258 - After performing the steps above I have double entries in the Experimental menu. It doesn't seem to affect anything though. When I install one it shows both installed. I'm not quite sure why.
231 lr-mame2003-plus (installed)
232 lr-mame2003-plus (installed)
Not sure bud have u tried rebooting retropie ? Sometimes these bash scripts cache in memory
List what's In your scriptmodules/libretrocores. see if there is more than one script for mame2003+ if a reboot don't help
@grant2258 - Yes, there's two entries lr-mame2003_plus
and lr-mame2003-plus
. Who's the real McCoy?
did you reboot and can you post a list of your scriptmodules/libretrocores dir please
The script worked fine for me, I only have one entry. Did you update the Retropie setup script ? Maybe that created the second entry.
should fix on reboot its probably the script cached somewhere in the bash env or there are two scipts in the libretro dir. I never use that menu just checked mine also only have one one listing
@ZappaUtopia - Yeah I usually update to the newest RetroPie script before updating emulators. It almost seems like a good practice now.
@grant2258 - I have rebooted it a few times but it's still there. The Pi is definitely not like a PC for me and rebooted all the time. My PC can be running for weeks between reboots.
If no one else is having the issue then it's probably just my build and I'm ok with that. I did the previous compile workaround too.
I think your initial assumption was correct from looking at my post above those files names are different. I am sure if I delete one of those double script files it will go away but which is the correct .so script to keep and which one to delete?
just post a ls -al scriptmodules/libretrocores
from the Retropie-Setup so we can see what in the @Wilstorm
not sure whats happend your end @Wilstorm this should fix it though
cd /home/pi/RetroPie-Setup/ sudo git reset --hard sudo git clean -f sudo git pull wget https://github.com/grant2258/mamemagic2003/raw/master/lr-mame2003-plus.sh sudo mv lr-mame2003-plus.sh scriptmodules/libretrocores/
Sorry I might not be explaining myself clearly. There's two scripts listed in the folder you suggested to look at. I believe one of these scripts below needs to be deleted and that will remove the double entry from the menu. If you notice after 2003 one has a dash and the other an underscore. I assume the script name was changed but I'm not sure if it should be a dash or underscore.
Or will running that command cleanup the extraneous .sh script.
lr-mame2003_plus.sh
lr-mame2003-plus.sh
I just tried to build from source (on Retropie) but it failed. Last few lines of the log say