B.Rap Boys (World)

[Cibomatto2002]

B.Rap Boys (World) has a popping sound playing when the music is playing. This games needs to say imperfect sound. Newer MAME this does not happen.

[mahoneyt944]

@arcadez2003 did a major update to this driver making many of these playable at all. Quite a bit of work by the looks of it. Of course there maybe something overlooked or a regression with a sound core update after the fact to check into...possibly an additional fix needed as well. Thanks for reporting this, we'll have to see what's going on.

[arcadez2003]

Actually it was IQ_132 and BritneysPAIRS that updated the Kaneko 16 driver my only input was to port it across to here not an insignificant contribution right enough as i fthen ixed some graphical and sound issues in some of the games and added support for Pack n Bang Bang and Wing Force :)

Anyway less of memory lane and more to the question at hand......

0.190: Fixed a longstanding INP playback desync bug caused by a rand() call in the MAME core (emu\ioport.cpp), fixed playback lose sync in B.Rap Boys [Angelo Salese, hap] 0.135: David Haywood changed sound banking on B.Rap Boys to use an OKIM6295 address map and banks. Changed region samples to oki1. 0.134u1: Kitsune Sniper, hap, Haze and Guru fixed music samples looping incorrectly / ending too soon in B.Rap Boys and clone. Changed clock speeds of the 2x OKI6295 to 2MHz and VSync to 59.185400 Hz.

I think we have the fix from 134.u1 the other two not so much, maybe that is what we need maybe it's not im busy just now with other things but i might come back to look at fixing not only the sound but the gfx niggles these games have down the road...

But that would require the video changes @MistyDreams was keen to add some time back.

[MistyDreams]

changing the frequency to 11999 should fix this

https://github.com/libretro/mame2003-plus-libretro/blob/6a475f7399d6c68a71f4276b9898e42853fe6353/src/drivers/kaneko16.c#L5362

[arcadez2003]

Aye worth a try i suppose

[mahoneyt944]

Do the other games play nice with this change or would we need to split them.

[arcadez2003]

Well all this drama over a simple question as to if the above change for B-Rap Boys sound will have a negative affect on the other games that share okim6295_intf_2x12kHz eg.......

Great Thousand Mile Rally Great Thousand Mile Rally 2 Shogun Warriors

Personally i'd wanna know that so would have tested after making such a change hence why i didn't volunteer :)

[MistyDreams]

Dont blame you @arcadez2003 it wont break any. Might as well leave on a positive note with a useful comment.

[MistyDreams]

@Cibomatto2002 change your sample rate to 44100 in the core options to get round this without any source changes. Its and easy fix for the core devs to stop it happening.

[arcadez2003]

Sure it's easy but i cant be assed tweaking the sound clocks and then having to test all the games affected just at the moment there are three other cores i work on ya know.

B-Rap Boys
Great Thousand Mile Rally Great Thousand Mile Rally 2 Shogun Warriors

Rather than telling us how simple it is why dont you just do it.??

[MistyDreams]

Telling the user how to fix this issue for this port. I doubt the other cores your working on will have this issue to begin with.

[Cibomatto2002]

@Cibomatto2002 change your sample rate to 44100 in the core options to get round this without any source changes. Its and easy fix for the core devs to stop it happening.

That fixed it maybe that should be the default setting for all games that use this core. Do I need to close this or leave it open?

[mahoneyt944]

That's just a temporary workaround until the proper rate is implemented. We'll close this for you once the code is pulled and tested.

[arcadez2003]

Im gonna do it now i guess since no one else wants to tackle it

[mahoneyt944]

Lol joking aside. Thanks 👍

[arcadez2003]

Well here is the potential fix and another for Great Thousand Mile Rally 1 and 2 https://github.com/libretro/mame2003-plus-libretro/commit/62408bb3c494a087e1b50878d25623064a15e62a

[mahoneyt944]

@Cibomatto2002 can you confirm this fixes you issue? Update from source.

[Cibomatto2002]

It is fixed now thanks to everyone that help get this fixed .