TODO: streamline 'external_hiscore' core variable - automatically external if present

[markwkidd]

These days the hiscore memory maps are built into the core, but at the very sensible request of jools from RetroPie there is still an option to use an external hiscore.dat.

Being able to have an editable DAT is useful in case for example you are trying to backport hiscore maps from later versions etc.

I've been thinking that the core option could be streamlined out as has been the old cheats core option. The new concept is the same as with cheats -- automatically check the external file first if it's present and move along gracefully if the external hiscore.dat doesn't exist.

The new logic would be 1) if hiscore.dat exists as a file in the system folder, look there first for the hiscore map 2) if no hiscore.dat or the hiscore map is not found there look in the internal database for the hiscore

The current logic is

• if user selects to use an external hiscore.dat load it from the system folder. if it's not there, give up.
• if the user selects not to use an external file, look in the internal hiscore database

[markwkidd]

We winded up with a more straightforward solution proposed by grant, where the hiscore.dat is simply spawned into place if and only if it is missing.

Regardless, closing as fixed.