Latest build, Mame2003+ not saving any files, lots of games not working

[ghost]

I'm using RetroPie. Just built the latest source using @grant2258 's script and found that the following games just exit to emulationstation.

backfire brapboys deluxe5 hedpanic mchampdx shogwarr swatpolc superman tangtang

bang (used to work on an older version of lr-mame2003 but now doesn't work on 2003 or 2003+)

I used the 'Generate DAT' option in the MAME menu and rebuilt the roms.

[markwkidd]

Thank you very much for testing and filing an issue.

I would like to ask one almost unrelated question: what MAME collections did you use to rebuild your romsets for mame2003-plus? It would be great to be able to tell users what ingredients they need in order to assemble all of the mame2003-plus romsets.

Why can't I answer this question myself? Until recently I had a variety of complete MAME collections available but my home was burglarized and they took my fileserver and its backup. What a drag.

[Wilstorm]

@markwkidd - Yikes! That's a true shame of some people. Will your homeowners insurance cover it? I keep an off-site backup at work. Actually 2 identical at work. To many years of "stuff". I was on your page this past weekend and I would have never guessed you are a gamer! ;)

Before the break here's what I used. MAME current, rollback current and a few unofficial ROMs. I'm not sure if there's any other unofficial ROMs yet. I have in-laws in town but I'll try and get a set built. I remember trying earlier sets so people don't have to start from the current set but I can't quite remember what was all missing. Maybe Zappa can fill that part in unless he starts from current also.

MAME 0.196 MAME Rollback 0.196

Hyper Street Fighter II: The Anniversary Edition (Asia 040202) [folder: hsf2a - size: 45mb]
missing rom: hs2ax.03 [size: 524288] [CRC32: 5f3d7397] [SHA1: 96f327dd998105ad5dc46bc9d3b741805a840d68]
missing rom: hs2ax.04 [size: 524288] [CRC32: 59acf108] [SHA1: e68fe233681175b29a35badab249c2b892b23af3]

[ghost]

Like Wilstorm, I have a full Merged 0.197 set and the Rollback set but my Mame78 collection is hand picked. I don't see the port of thousands of clones unless they are drastically different like Rainbow Islands Extra etc.

The games I listed as not working in the first post are mainly the new ones that Arcadez added so i'm not sure why they don't work. I know that brapboys and shogwarr definitely worked on my previous build a week a go.

There maybe more games that don't work but I was mainly trying to get the controls to work after the recent "control" updates and was a bit unsuccessful, why or why was it changed ? If it ain't broke, don't fix it ! :)

[Wilstorm]

my Mame78 collection is hand picked.

Same here I have a whopping 327 games total but I've been adding a few here and there.

[ghost]

please check the /dev/shm logs see if its giving you any clues. I havent really used mame2003+ much at all since the input changes been busy with stuff to be honest

[ghost]

see here for tan tang https://github.com/libretro/mame2003-plus-libretro/issues/148

[ghost]

GAME( 1999, multchmp, 0, multchmp, multchmp, 0, ROT0, "ESD", "Multi Champ (World, ver. 2.5)" ) GAME( 1998, multchmpk,multchmp, multchmp, multchmp, 0, ROT0, "ESD", "Multi Champ (Korea)" )

/ ESD 05-28-99 / GAME( 1999, hedpanico,hedpanic, hedpanio, hedpanic, 0, ROT0, "ESD", "Head Panic (ver. 0615, 15-06-1999)" ) / 15/06/1999 ?/

/ ESD 08-26-1999 / GAME( 2000, mchampdx, 0, mchampdx, hedpanic, 0, ROT0, "ESD", "Multi Champ Deluxe (ver. 0106, 06-01-2000)" ) / 06/01/2000 ?/ GAME( 1999, mchampdxa,mchampdx, mchampdx, hedpanic, 0, ROT0, "ESD", "Multi Champ Deluxe (ver. 1126, 26-11-1999)" ) / 26/11/1999 ?/ GAME( 2000, hedpanic, 0, hedpanic, hedpanic, 0, ROT0, "ESD", "Head Panic (ver. 0117, 17-01-2000)" ) / 17/01/2000 ?/ GAME( 2000, hedpanicf,hedpanic, hedpanic, hedpanic, 0, ROT0, "ESD", "Head Panic (ver. 0315, 15-03-2000)" ) / 15/03/2000 ?/

/ ESD - This PCB looks identical to the ESD 08-26-1999 PCB / GAME( 2000, deluxe5, 0, tangtang, hedpanic, 0, ROT0, "ESD", "Deluxe 5 (ver. 0107, 07-01-2000)" ) GAME( 2000, tangtang, 0, tangtang, hedpanic, 0, ROT0, "ESD", "Tang Tang (ver. 0526, 26-05-2000)" ) / 26/05/2000 ?/ GAME( 2001, swatpolc, 0, swatpolc, swatpolc, 0, ROT0, "ESD", "SWAT Police" )

I'm using RetroPie. Just built the latest source using @grant2258 's script and found that the following games just exit to emulationstation.

backfire brapboys deluxe5 hedpanic mchampdx shogwarr swatpolc superman tangtang

bang (used to work on an older version of lr-mame2003 but now doesn't work on 2003 or 2003+)

[ghost]

just a driver update think that should be most of them covered. Ill look into this more myself need and get back to you on what i find. I know mame retropie has some dir setup issues at the moment might or might not be related to that. I just dont feel like building romsets today lol

[ghost]

@ZappaUtopia what kind of dat did you generate conven or alter? so i can trace your problem

[ghost]

yea i can confirm there is problems with the xml dat now not sure what changes where dont but the parent clone realationships have been messed up

[markwkidd]

Argh.

On Wed, May 2, 2018, 5:58 PM grant2258 notifications@github.com wrote:

yea i can confirm there is problems with the xml dat now not sure what changes where dont but the parent clone realationships have been messed up

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386146998, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdkFxY-FAl8E5q2QSIkU4Gz0nsCUWks5tujoxgaJpZM4TvkAo .

[ghost]

ill be fixable mark probably one line of code its the usual way gettng errors for samples and

Set: 9-Ball Shootout (set 1) Name: 9-Ball Shootout (set 1)

Issue: Parentfolder 'coolpool' doesn't exist

Parent/clone relationship will be removed.

[ghost]

@markwkidd i can tell you where to get full sets just done wanna plublish that info on here mate dont think its the right decorum ill send you a private messge on retropie dont know how to do it here

[ghost]

well i just looked at the xml mark just generate it and have a peek youll see the problem right away it just displaying the game name no xml tags. never mind this comment was internet exporer see problem below.

[ghost]

thinks its something to do with the samples mark best info i can give you atm is

"XML Parsing Error: not well-formedLocation: file:///media/grant/empty/Download/Emulation/roms/arcade/mame2003-plus.xmlLine Number 216320, Column 20: ---------------------------------^"

ps edit this to see the text properly mark

[ghost]

    <sample name="F)9\DEy"/>

error seems to be arising from tmnt mark hope this helps. The parent clone is still messed up though. I think it would be be best to use the original code untouched for the conventional and a seperate function for the alternative mark

[ghost]

@markwkidd for the new format

the clone of and romof format needs changed for the style change as well

[ghost]

static void print_game_info(FILE out, const struct GameDriver game) { extern struct GameDriver driver_0;

fprintf(out, "\t<" XML_TOP);

if(old_style)
fprintf(out, " name=\"%s\"", game->name ); /* use GameDrv "name" field as the filename */

else fprintf(out, " name=\"%s\"", game->description ); / use GameDrv "description" field as the filename /

if (game->clone_of && !(game->clone_of->flags & NOT_A_DRIVER))
    fprintf(out, " cloneof=\"%s\"", game->clone_of->name);

if (game->clone_of && game->clone_of != &driver_0)
    fprintf(out, " romof=\"%s\"", game->clone_of->name);

print_game_sampleof(out, game);

fprintf(out, "%s", ">\n");

can you explain the code

print_game_sampleof(out, game);

fprintf(out, "%s", ">\n");

shouldnt this be wrapped round if starements i think thats where the sample problems originate from

[ghost]

ill look at the code if you like but seems there has been a few changes to info.c dont want to break anything you might want kept

[ghost]

i think i found the problem with tmnt

struct Samplesinterface { int channels; / number of discrete audio channels needed / int volume; / global volume for all samples / const char **samplenames; };

static struct Samplesinterface samples_interface = { 1, / 1 channel for the title music / 100 / volume / };

think we need to set that to null else it will use whatever is in memory at the time ill test first if this will have any effects on the game before changing in a commit

[ghost]

actually we are getting a segfault when generating a dat file now as well will need to look into this a lot more and trace whats going wrong.

@markwkidd start tmnt do a xml dump you get a segfault

start 1941j do a dump its fine dont know if this is new to the code you done or if the issue was always there either way the the dat is broken for now as is

[ghost]

@markwkidd dat is generated fine on the retropie (conventional) i think the info.c samples code isint 64 bit friendly) confirmed by segfault disappearing when setting the debug flag on 64 bit compile disabling optimization

[ghost]

@ZappaUtopia its fixed now i fixed the 64 bit dat creation on 64bit. Im guessing like me you just generate the dat from retroach because its working fine on 32 bit well the conventional one is and always was. The alt needs some teaks no bugs per say just tweaks ill leave that in marks capable hands i dont want to mess his versioning up. I wouldnt have picked this bug up if i wasnt using 64bit

If your going to build a dat from a 64 bit machine make sure you update first to the comit i just done. Im going to have a game of slapfight now i love this game cheers @arcadez for adding this! i update the metadata to the latest dat produced on a 64bit and tested a few games in your list seems good didnt test them all let me know if there is any more issues with these roms above not working after you rebuild.

[ghost]

@markwkidd the alt needs some tweaks for parent clone relationships it nothing major just an oversight

game name="PuckMan (Japan set 2)" cloneof="puckman" romof="puckman"

all the of conditions for this should be using the description for the parent clone relationships

[ghost]

@grant2258 I just built from source again and tested the games I listed in the first post, none of them work. It's probably to do with what you said about MAME not saving NVRAM etc.

I have always used the original DAT method (8.3 filenames). I don't like the look of the full filenames as I won't be able to scrape.

[ghost]

Im pretty sure all of those games use an nvram save file, have you tried just removing one to see if the games will then boot once more try this with Tang Tang.

[ghost]

there is a problem with nvram atm see input thread

[ghost]

@ZappaUtopia please verify your roms with the dat here https://github.com/libretro/mame2003-plus-libretro/tree/master/metadata superman is working on retropie

[ghost]

@grant2258 My roms are fine, there was never anything wrong with them. That DAT is the same as the one I generated from the MAME menu.

[ghost]

Bug should be fixed one of line of code was missing. Mark has done so much work lately and it's made things easier for us all to work in mame people really should take the time thank him. If i was doing the changes he done of late there would be more than one line of code missing thanks for all the hard work mark

[markwkidd]

Yep, I did the deed, and accidently changed one very important line. It's good working with you grant, you're patient!

On Fri, May 4, 2018, 1:30 AM grant2258 notifications@github.com wrote:

Bug should be fixed one of line of code was missing. Mark has done so much work lately and it's made things easier for us all to work in mame people really should take the time thank him. If i was doing the changes he done of late there would be more than one line of code missing thanks for all the hard work mark

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386515554, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphduU36o2y0NxK_ql12dr_ZT9jxVw1ks5tu_VqgaJpZM4TvkAo .

[Wilstorm]

Agreed, I do really appreciate everything you do Mark. I am still in awe when I sit down and play arcade games on my TV. I love it! It's an incredible feeling of nostalgia that I can never quite get enough of. Grant you and Arcadez also for your guys programming skills and his vision to start it all, I enjoy the small talk with you guys and reading your comments and commits even if I don't understand all of them.

On a side note I saw on the RetroPie forums someone trying to download 2003+ but they were getting the download source error and also the nvram errors Zappa mentions. 2003+ isn't quite ready to create a thread correct?

If you layout some of the highlights of what's new and what sets 2003+ apart. Basically what you want people to know. I can start a thread when it's ready. I think @ZappaUtopia was correct once more people are using 2003+ you have a built-in beta tester group that have an easy place to report bugs.

[ghost]

Well right now it doesn't even compile on retropie. That's going to have to get fixed first. It should be in a workable state now anyway. We do need to branch off for bigger changes now I would imagine. Its not like it was when we first started. I think we need some kind of stability for users and branches for testers then bring it in when we are done with the branch we are working on.

[markwkidd]

I've just posted a new RetroPie-Setup issue where I'm hoping to talk with jools about getting the script fixed up

On Fri, May 4, 2018 at 9:41 AM, grant2258 notifications@github.com wrote:

Well right now it doesn't even compile on retropie. That's going to have to get fixed first. It should be in a workable state now anyway. We do need to branch off for bigger changes now I would imagine. Its not like it was when we first started. I think we need some kind of stability for users and branches for testers then bring it in when we are done with the branch we are working on.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386623054, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdjerd6mFOlTKiLfynIuy3iseYUWGks5tvGihgaJpZM4TvkAo .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

[ghost]

well the thing is we need to setup default values as well like bi-lin filtering and some sensible options for input method and layout so people can use it as is. I am in agreement we need to start getting active on the retropie end for a user base of testers

[Wilstorm]

Yeah I think once a thread is created it will open the flood gates for posts. You would definitely want to be ready. I think 2003+ is more about attraction vs. promotion or very little would be needed at most. Some of the fixes are just a win-win-win! :)

[ghost]

to be fair we just work on the core its @arcadez that done the all the big changes for adding more games that made mame2003+ possible

[Wilstorm]

Yes I remember. I liked when Darknoir would post pics of the new additions. Nothing like a good visual! I kind of wish he was on the forums when you're ready to post over there but then again he might not want to be in the middle of all those questions! A "new" product always creates and is surrounded by buzz! :)

[Wilstorm]

@grant2258 - Just for you, maybe, if you like! ;)

Frontend developers ?

Here is how History should be reads:

info for games on $info=rom1,rom2,
info for machines on $info=bios1,bios2,
info for softlist on $(softlist name)=rom1,rom2,

[ghost]

well the mame input system is a bit iffy now not sure how we should be setting different things. If you select a key and press the same key again its says 1 or 1 or ect 1 it shouldnt be setting it if thats keys already been selected and how do you clear the table completely now. This is just little niggles that will be worked out in time. The problem is we have the keyboard retropad and sim mode now so some thinking will probably be need to accomadate all 3

[markwkidd]

Thankfully in the MAME menu you can clear input maps the same as with MAME 0.78. Is that what you are referring to? Select the input you want to remap, but instead of pressing the new key press the right arrow twice. That's if the user want to clear an input, and only works one at a time of course.

On Fri, May 4, 2018 at 11:02 AM, grant2258 notifications@github.com wrote:

well the mame input system is a bit iffy now not sure how we should be setting different things. If you select a key and press the same key again its says 1 or 1 or ect 1 it shouldnt be setting it if thats keys already been selected and how do you clear the table completely now. This is just little niggles that will be worked out in time. The problem is we have the keyboard retropad and sim mode now so some thinking will probably be need to accomadate all 3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386647238, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdsCuF94-ETmvtfe_ebAe48aZNfFKks5tvHuIgaJpZM4TvkAo .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

[ghost]

its just says retropad right retropad right when i press the arrow keys when testing on windows mark. Never mind its me i think im getting old its working. The only other issue is you can bind the same key many times not a big deal if you clear it. I think my laptop keyboard is a little funky at times might need replacing seems to have off behavior when typing sometimes too.

[ghost]

This menu will be going soon anyway no point in doing any work to it. It can be reset and set that's all we need. I am curious to see how the different modes effect the default.cfg if they do at all I'm pretty sure it shouldn't anyway

[markwkidd]

Ah hah. I've only been using a keyboard to test so I'm guessing it doesn't look for the right key when it's coming from the joypad.

I imagine this can be fixed so joypad works like jeyboard. I'll take a look soon

On Fri, May 4, 2018 at 11:25 AM, grant2258 notifications@github.com wrote:

its just says retropad right retropad right when i press the arrow keys when testing on windows mark

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386653529, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdrRfh6ccEbDf39-bzQRhTpD6gA0wks5tvIDsgaJpZM4TvkAo .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

[ghost]

@ZappaUtopia can we close this now issue is fixed we need to keep track of issues and close them.

[ghost]

@grant2258 I just built from source and the games still don't work. It's not saving anything in the 2003+ directory. I am still using your script to build.

[ghost]

must be your roms @ZappaUtopia add the --verbose output to see whats going on retropie by default doesnt show any retroach logging

[ghost]

@ZappaUtopia where are your roms located in retropie the directory the roms are in

ie is it

/home/pi/arcade/superman.zip or is it /home/pi/arcade/mame2003plus/superman.zip

also whats your input method and layout options. I get the feeling its roms if the games are just not starting

[ghost]

have to get ready for work but ill check in when i get back

[ghost]

Other games are working fine but nothing is being saved in the Mame2003+ directory for any game or controls. No Nvram files, no cfg files, no default.cfg, etc. https://github.com/libretro/mame2003-plus-libretro/issues/157#issuecomment-386204112