Closed ghost closed 6 years ago
im off to bed myself need to get zome zzs. I would try updating first if your on stretch in all honesty its fairly new
a note on the high scores not being saved see here http://highscore.mameworld.info/nvramtest.htm im pretty sure @markwkidd has implemented something like this.I havent looked at this part of the code but i think i seen a thread about something like on retropie im sure he will fill you in on the highscore issue.
I upgraded Raspbian (Stretch) kernal and firmware. Then ran this -
gdb -args /opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-mame2003-plus/mame2003_plus_libretro.so --config /opt/retropie/configs/mame-libretro/retroarch.cfg "/home/pi/RetroPie/roms/arcade/tangtang.zip"
run
bt
This is what it said -
#0 0x0006a574 in state_manager_push_do ()
#1 0x0006afd0 in state_manager_check_rewind ()
#2 0x00020450 in runloop_check_state.isra ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
Also tried a few more working games and still no hiscore files. We're going down the beach now. I'll check back tonight.
ZappaUtopia I wish I could buy you a beer. You may be the most patient tester I have ever encountered on github -- if things are going wrong for you that are normally working for other people, it's probably because you have been willing to test so many different things for us here and it's led to some obscure issue.
Meanwhile you really have been helping us find bugs! At least two completely distinct bugs so far this weekend. It's appreciated and is helping prevent other people from having to go through troubleshooting.
I just wanted to say that before I get out of the way for more discussion amongst the actual RetroPie users.
On Sun, May 6, 2018 at 6:43 AM, ZappaUtopia notifications@github.com wrote:
I upgraded Raspbian (Stretch) kernal and firmware. Then ran this -
gdb -args /opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-mame2003-plus/mame2003_plus_libretro.so --config /opt/retropie/configs/mame-libretro/retroarch.cfg "/home/pi/RetroPie/roms/arcade/tangtang.zip"
run
bt
This is what it said -
0 0x0006a574 in state_manager_push_do ()
1 https://github.com/libretro/mame2003-plus-libretro/issues/1
0x0006afd0 in state_manager_check_rewind ()
2 https://github.com/libretro/mame2003-plus-libretro/issues/2
0x00020450 in runloop_check_state.isra () Backtrace stopped: previous frame identical to this frame (corrupt stack?)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-386873337, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdlShK_GXl__4qcSK6WtAx_4iJfw2ks5tvuHsgaJpZM4TvkAo .
-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115
Thanks for the kind words @markwkidd and I appreciate everything that you and @grant2258 have done to cooperate and iron out the bugs with your skills !
I found another game that no longer works, Sexy Parodius.
Regarding the High Scores not saving, I can't really believe that it's working for everyone except me ! I looked through the RetroArch options and chose the option to use the external hiscore.dat. Lo and behold, the hiscores are now saving ! So the built-in hiscore support is broken.
You need to reboot for the system updates in the kernel.
oops think over written your comment turn load and save states off in retroach need to get ready for work though. I dont check hi scores its not something i use.
It's a shame that there's no-one else that can confirm my problem with certain games not running. @grant2258 Did you say that hiscores also work on yours even though I had to use the external hiscore.dat to get them to save ? If the built-in hiscores are broken then maybe something else is slightly broken that's preventing these games from running ?
I noticed on Superman that when running I very briefly see the scores at the top of the screen before it exits, and another game gave me the screen about 'pressing OK or left/right to continue' before it exited.
@markwkidd state_manager_push_do () is a retroarch function isint it?
@ZappaUtopia please start mame with a game that works. Then go into the rgui and got settings saving turn all these options off and save the configuration. I think some how your save states are on they shouldnt be for mame save it as a core override if you need it other emulators. If this is a global setting it would effect mame2003 as well its unsafe to use this feature in mame some games will not work properly.
@ZappaUtopia i have not looked into the high scores yet but will if mark wants a extra pair of eyes i dont mind looking. I dont like walking over other peoples coding when they are working on it. i never ever use hi scored unfortunately because my configurations get deleted so much in testing. I dont see any directory's created but im pretty sure my setting is on the dat atm
I checked the 'saving' menu and all options are off. I looked and checked through several options and found one called 'rewind' which was on. I have never used this option or changed it, I have only fairly recently copied a fresh install of RetroPie. When I turned that option off the games now work ! Sorry guys.
Maybe you could make Mame turn that option off in the code otherwise certain games are not going to boot. Sorry for the troubles.
I think Wilstorm uses Retropie but his last 5 comments have been nothing to do with MAME :)
Ah shoot, I know I get off point. It was late and Grant seemed like he wanted to blow off some steam and shoot the breeze a little. It was a perfect moment and I found his video spot on and funny. Good sense of humor I appreciate. I like to see the other side of these guys and not just the hardcore programmer. :)
I do actually use RetroPie. It's just I've been in a tail spin since my wife's accident so my free time has been severely limited as of late. I'm getting about 5 to 6 hours of sleep at night. It'll be a few weeks before things turn around and get back to normal I think.
@grant2258 - I pulled the DAT down this morning to take a look and I think there's an issue. I could open a new case if you want it documented. What I think you did is added the alternative CD audio samples as the "correct" samples? Anyway nbajam is using a sample set named nba_jam which will be interpreted as a missing ROM set named nba_jam but will still add the sample set. I might be beneficial to name it nbajam to match the parent ROM.
not need to file an issue i did see this in clrmame ill need to look at the code and confirm and changes with @KMFDManic that he is ok with this change.
@grant2258 - Ok, I figured you probably caught it. it will definitely work the way it is but ClrMamePro will throw an error that it's missing a ROM set when really it isn't. I think it's one of those snafus that the dev [of ClrMamePro] has to decide what to do with it scenario even though there's no option really. Renaming it to match the parent should resolve it though.
I do agree with you just want to make sure there wasnt a reason it was set this way in the first place. I really dont see there being any issues changing this. Its always good to ask the people reasonable first before changing so the changes go to there own ports as well
Ah ok that makes sense so he may update his code too. Sorry for the half baked thought when I said dev I meant ClrMamePro. He is tasked with a scenario that really isn't an issue but is more of an oddity so it throws a message that has no option except to let you know what it's seeing. It's actually really handy if you think about it and he's covering all scenarios.
I suppose these type of "errors" are just confusing for most users and really don't need to see them at all since there's no decision to be made. That other ROM management program (MAME Set Rebuilder I believe you wrote it works for Windows so I would like to test it) might fit the bill since it really only needs 3 parameters and makes the rest of the decisions for the user. It basically removes the options from the users so it's a great starter ROM management program or possibly all that is needed ever.
I personally don't like to merge my BIOS ROMs and wouldn't mind seeing 2003+ allow for flexibility like AdvMAME.
An issue with the BIOS is when using the Arcade folder and combining ROMs from multiple emulators. I added the neogeo.zip to the BIOS folder which works fine. Then when I add mame2003 games I need to add another BIOS file (in the ROM folder).
The issue is now the FBA games crash because they must have a search path and look to the ROM folder (arcade) first and find the mame2003 BIOS. Mame2003 games work though. If I located the FBA BIOS in the ROMs folder they work and mame2003 games crash. I could combine the BIOS into the game ROMs for FBA and/or mame2003 and leave the other in the ROM folder itself. That would resolve the issue of combining ROMs from multiple emulators under the Arcade folder.
I like AdvMAME in that you can set a search path and it can be located anywhere which avoids this conflict. I hope that makes sense.
@Wilstorm I didnt write that emulator the only way i see to fix this is rename the neogeo bios in one of the emulators which will panic the masses using that emulator, Im havent used fba not sure why the neogeo bios should be different anwyay
@grant2258 - That seems a bit extreme to rename the BIOS. Yeah that would probably never fly. The issue arises when using the Arcade folder only otherwise it's not an issue using emulators individually.
The way I understand it from trial and error is the search order for FBA is ROM -> ROM Folder -> BIOS folder
. If it was ROM -> BIOS Folder -> ROM Folder
it would work or possibly force the BIOS to a folder like mame2003-plus/BIOS and mame2003/BIOS or something along those lines. I think there's several ways to skin the cat here. AdvMAME has a search path you can add to the config file and done, no conflicts, quick and easy.
You would think the FBA BIOS being newer would work with mame2003 or Plus but it doesn't so you forced to merge the BIOS or migrate all BIOS games to one emulator or other remembering it's only when using the Arcade folder.
it's a bit of a niche use case as neogeo emulation is all via one driver in the respective emulator, so there shouldn't be a need to 'share' neogeo emulation across different emulators. you're not going to have a situation where emulator x is the best emulator for subset a of neogeo games, and emulator z for subset b.
(i would say fbalpha is the better neogeo emulator - it's accurate, covers the whole set, plus hacks, allows neogeo cpu overclocking, and is the most mature libretro arcade core anyway)
plus there's a neogeo subfolder in retropie if you want to further isolate them, so that gives you 4 folders (mame-libretro, fbalpha, neogeo, arcade) where you can put subsets of neogeo games and associate them with specific libretro neogeo emulators (lr-mameX, lr-fbX, etc), if for whatever reason you want to do that :)
@dankcushions - I'm in the niche with all the other Arcade folder users. It's nice to say we should all roll over to FBA because "it's the best" but I am mainly setup with the mame2003 family and would like to see where Plus goes as an emulator. I was just suggesting something that was maybe easy to do by altering the search path order or adding a search path variable like AdvMAME does.
Obviously folder isolation which I have used 3 of those extensively isn't the goal. It's more BIOS isolation when combining ROM sets under Arcade. I've never tried the neogeo folder if it could be attached to lr-fbalpha that might work as I would hate to build out another set for a "3rd party" emulator just to avoid the BIOS conflict. I think if you have to go that far you might as well combine the BIOS.
I personally just use sub folders in my mame-libretro mame2003_plus_split MAME2003_Split
I've never used subfolders under the main emulator folder? How does that work? Is that in the RetroPie Wiki?
look here https://github.com/RetroPie/RetroPie-Setup/issues/2397#issuecomment-387118742 and raise any point if you need to @Wilstorm. shrugs its not in the wiki its not really the way you should be doing it its the way i do it though
Oh yeah I was speaking strictly of BIOS overlap. Yeah it's like Dank pointed out you mainly have 4 folders that all those emulators are running under (mame-libretro, fbalpha, neogeo, arcade). It just dawned on me you don't use RetroPie or you wouldn't have asked those questions! ;)
The BIOS conflict has been discussed extensively on the forums and maybe it's not an easy task to switch the search path or add a path. When using Arcade standalone emulators like AdvMAME are included in the BIOS conflict. It's just that the AdvMAME dev slapped in a search path and said now you guys decide for yourself where to locate the BIOS. Now if mame2003 & FBA had that type of flexibility it would make Arcade perfect.
What Arcade allows is I can pick the best ROMs from all the MAME emulators and locate them in one folder. So when I launch say an exclusive 2003+ game it will run 2003+ but further down the game list I launch Tempest then AdvMAME runs the game and looks great. If it's a FBA title that runs perfect in that emulator use it! It's incredibly useful.
It does come with caveats. You can only have one ROM named the same so pick the ROM for the preferred emulator and then there's the BIOS conflict because using multiple sets under one folder requires different neogeo.zip BIOS sets (some older legacy ROMs).
AdvMAME doesn't have this conflict because I can a for example create a folder /home/pi/RetroPie/BIOS/advmame
(or wherever) and then edit the AdvMAME config and add to the search path /home/pi/RetroPie/BIOS/advmame
. Then I copy my BIOS to the folder and done. No conflict with mame2003, 2003+ or FBA. It's a option that AdvMAME has which works very well when using the Arcade folder.
I do use retro pie i also use multiple sets of mame roms. I have the sets in the folder i need them to be in and it works,. If i want to change emulators i just pess a button when i pick a game. The retropie way of doing it is too limited for me and there is no way you can make a 2003 and 2010 set work on both with different roms sizes ect its just not viable and worth the extra work when all you need to do is pick a folder and change the default emulator. The real question you should be asking yourself is why are these folders even shared in the fist place each core should have there own imho if you should only be using one. This issue could be fixed on retropie but it is a retropie issue not a core issue needs fixed on a retropie level
Hmmm I don't see why you can't by modifying the launch command. I have done this and used alternate configs this way. The way RetroPie does it I can pick any game and it will launch with the preferred emulator. I can't argue it's not a lot of work setting up but now that it is complete I can port my entire config to future builds in seconds.
As you pointed out above you can press a key and change the emulator on launch. That's what RetroPie does too! I am not sure how you can use that feature if you have the same ROM from a 2003 and 2010 set because they would need folder separation so there's no need to press a key and change the emulator on a per ROM basis.
@Wilstorm Im only talking about retropie here retroach has no issues at all. I use multiple folders in my mame-libretro if im on mame2003 and want to use the mame2003+ i just pick the the mame2003+ folder and i says press any key to change setting and i change the default emulator to mame2003 or 2003+ or 2010 ect that way i can choose my roms and emulator by just changing the default emulator
The real question you should be asking yourself is why are these folders even shared in the fist place each core should have there own imho if you should only be using one.
because retropie is typically used with weak SOC systems where there's no one-stop solution for arcade emulation, so you might have several mame/fba cores that you need to cover playing all the arcade games you want (eg, cps3 in FBA), but at the same time you don't want loads of different 'systems' in emulationstation (one appears for each system folder), that you'd have to navigate through to get to a specific game. retopie allows you to have one folder with a bunch of roms from different arcade sets, and then pick and save an arcade emulator for each rom.
i just don't see this is a retropie problem - our use cases (dev, tester) are so niche, so you'll struggle to convince retropie to overhaul their current process.
Emulation Station uses folders for metadata even though it also has metadata from the xml file. It seems like an inherant limitation.
Retroarch alone is better about where content can be stored, but IMO until playlist version 2 comes along be it'll never look as nice.
On Mon, May 7, 2018, 1:07 PM dankcushions notifications@github.com wrote:
The real question you should be asking yourself is why are these folders even shared in the fist place each core should have there own imho if you should only be using one.
because retropie is typically used with weak SOC systems where there's no one-stop solution for arcade emulation, so you might have several mame/fba cores that you need to cover playing all the arcade games you want (eg, cps3 in FBA), but at the same time you don't want loads of different 'systems' in emulationstation (one appears for each system folder), that you'd have to navigate through to get to a specific game. retopie allows you to have one folder with a bunch of roms from different arcade sets, and then pick and save an arcade emulator for each rom.
i just don't see this is a retropie problem - our use cases (dev, tester) are so niche, so you'll struggle to convince retropie to overhaul their current process.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-387152370, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdko4eSBNjgliOlLikAVjEumtp5k1ks5twI1ZgaJpZM4TvkAo .
@dankcushions im not asking them too I do understand why it is the way it is but you can work round it by making a sub folders and changing the default emulator thats how I do it with zero issues there at all I dont use scarpers to be fair im just telling @Wilstorm how i work round it to use different mame sets
all i am saying is when there is cases that something could break the retropie model we have a #if defined retropie condition set on the retropie build script so we dont break the core on retropie and can do the changes we need for the core. We will be limited on what we can do if we dont do this long term in fear of breaking retropie
I wish I understood the emulator folders underneath mame-libretro you're building better. I've never done it this way even though what you're saying makes sense and is pretty much the same as RetroPie except the one scenario you pointed out. That you may run say for example dkong from 2003 and dkong from 2010 which I am not sure why you would want both anyway except maybe troubleshooting.
RetroPie is grouping emulators at a "class" level via the system folder but I can override at a core level whether it's the emulator or config. In RetroPie I press a key and pick my emulator or if you prefer just modify the config and add all your overrides manually. It's really clever and really not as limiting as you think, I think! ;) But I think this is where Dank understands everything as a whole but I just spend my time trying to get the games running the way I want and not viewing the whole system.
With the multiple folder option with multiple emulators what does your game selection screen look like? Can you link a screenshot? I know exactly what you're doing but curious what it looks like on the screen?
the screen mame or arcade screen will just show the folders
when you pick the folder after that its just the same as usual.
you need to restart emulation station though
i forget the name of that app that lets you take screen shots on the pie else i would take one for you
Isn't part of the goal to make 2003+ fully integrated with RetroPie as is the case with other emulators? I guess I don't mind some of the shortcomings of RetroPie as I find the Emulationstation frontend that can be skinned pretty damn awesome and not a bad looker either. :)
@grant2258 - I know what you're doing but I was hoping you could like a screesnhot possibly if not that's ok?
@grant2258 - Ah ok that's fine.
@Wilstorm mame2003 and mame2003-plus are libretrocores retropie runs libretro
@grant2258 - Yeah I know it just sounds contradicting when you say RetroPie is limiting but I always thought that was one of the goals but maybe the end-game is more about using the Retroarch frontend then integrating with RetroPie.
I love retropie it will never leave my barcade i made. It the sam issue libretro has sometimes it has a model to fit into so does retropie sometimes.
@Wilstorm the way retropie chooses to do directory for arcade games isint following the libretto model its not for us to decide how retropie does things and how its sets it end of retroarch up and deals with roms. jools said himself you pick what version of mame you want or fix sets up to work on more than one emulator. My alternative is use multiple folders and change the default emulator and your sets will be working properly
@grant2258 - I hear what you're saying and it makes sense as I start to see the line separation between Retroarch and RetroPie. It seems like Plus is going to hit some rough seas and some down time during an interface overhaul. You guys are developing a bigger picture. Maybe holding steady with lr-mame2003 for a while might be the way to go until it smooths out.
I can take a punch so have it but I think I might have been happy with just adding the games as Arcadez originally envisioned and just cleaning up the interface a bit. The game additions and fixes are the big pull for me.
@grant2258 - Out of curiosity how far ahead of New York time are you? I keep thinking this dude doesn't sleep. I catch you at all hours it seems from the middle of my day to the middle of my night! :)
@Wilstorm i work nightshift im in the uk so my sleeping pattern is messed up specially when i have days off mate!
These issuse have always been here even with mame2003 this same issue has always been there its nothing new. retropie pie runs retroach in the background you only see it when your in the rgui.
here is the screenshots
@Wilstorm the way retropie chooses to do directory for arcade games isint following the libretto model
there is no libretro model when it comes to file structures, though. it's all configurable. you specify where you want it to pick files up from. retropie doesn't specify savedir, so libretro defaults to content dir. that's normal libretro behaviour.
it's dead simple to solve for your setups, i think - just set savefile_path to blah/mame2003-plus/ (or wherever) in a core or game override.
@dankcushions im talkin
@Wilstorm the way retropie chooses to do directory for arcade games isint following the libretto model
there is no libretro model when it comes to file structures, though. it's all configurable. you specify where you want it to pick files up from. retropie doesn't specify savedir, so libretro defaults to content dir. that's normal libretro behaviour.
it's dead simple to solve for your setups, i think - just set savefile_path to blah/mame2003-plus/ (or wherever) in a core or game override.
yes that solves the mame save stuff thats a separate issue though and not really a big one tbh if you know whats going on. im talking about using different mame sets on emulation station it is possible this way and all you have to do is change the default emulator and you dont have multiple menu screens
These days the libretro api does recommend a separate save folder, but there are plenty of projects that started off before that was part of the spec, I am sure including RetroPie. It's not recommended to not have a save folder, but not prohibited
On Mon, May 7, 2018, 2:06 PM dankcushions notifications@github.com wrote:
@Wilstorm https://github.com/Wilstorm the way retropie chooses to do directory for arcade games isint following the libretto model
there is no libretro model when it comes to file structures, though. it's all configurable. you specify where you want it to pick files up from. retropie doesn't specify savedir, so libretro defaults to content dir. that's normal libretro behaviour.
it's dead simple to solve for your setups, i think - just set savefile_path to blah/mame2003-plus/ (or wherever) in a core or game override.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-387170134, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdl5sHeKUeL-xgDES_46B22iMRVRDks5twJtLgaJpZM4TvkAo .
I personally dont see the problem with making a /home/pi/Retropie/retroachsavefiles and pointing to it might save some heartache if other cores update like mark said nothing is set in stone that issue i can live with as is to be honest as long as users are aware of this it wont be a problem..
We could always recommend that as an "alternate configuration" for RetroPie users in the README
On Mon, May 7, 2018 at 2:25 PM, grant2258 notifications@github.com wrote:
I personally dont see the problem with making a /home/pi/Retropie/retroachsavefiles and pointing to it might save some heartache if other cores update like mark said nothing is set in stone that issue i can live with as is to be honest as long as users are aware of this it wont be a problem..
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/163#issuecomment-387175297, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdh-DUma7mbeVXpODfswK-1S_E635ks5twJ-ogaJpZM4TvkAo .
-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115
These days the libretro api does recommend a separate save folder
can you show where? here doesn't specify: https://github.com/libretro/RetroArch/blob/master/libretro-common/include/libretro.h#L790 - in fact seems pretty cool with you not having one set!
i really don't think you need to note this kind of stuff in the readme btw - it's such a niche issue that i'm convinced would only affect the people in this thread :) splitting out in to sub directories has historically caused issues in emulationstation and other non libretro-emulators. i think previous versions of mame2003 wouldn't have permitted it either - i believe an earlier ersion used to use /content/mame2003/x/ folders for the hiscore.dat (it was later moved to system dir/mame2003, etc) no one complained then!
Well, there are two sections a little out of sync in language. You're right it's not very specific in the place you linked.
[Using the SYSTEM folder for save storage] is now discouraged, and if possible, cores should try to use the new GET_SAVE_DIRECTORY.
https://github.com/libretro/RetroArch/blob/master/libretro-common/include/libretro.h#L539-L542
I've been submitting clarifications to the language of libretro.h -- maybe this is another one where I can find out for sure the answer myself and then clarify what's written in the API.
@dankcushions very true i can see how that would effect the retropie model I really do its just easier for me for using multiple sets if i choose too im not asking for anything to be changed. i just offering an alternative to not building complicated romsets.
I'm using RetroPie. Just built the latest source using @grant2258 's script and found that the following games just exit to emulationstation.
backfire brapboys deluxe5 hedpanic mchampdx shogwarr swatpolc superman tangtang
bang (used to work on an older version of lr-mame2003 but now doesn't work on 2003 or 2003+)
I used the 'Generate DAT' option in the MAME menu and rebuilt the roms.