libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
188 stars 108 forks source link

Hamaway #1685

Closed arcadez2003 closed 7 months ago

arcadez2003 commented 7 months ago

Thank you wanting to make a contribution to this project!

Please note that by contributing code or other intellectual to this project you are allowing the project to make unlimited use of your contribution. As with the rest of the project, new contributions will be made available freely under the classic MAME Non-Commercial License.

This license can be viewed at https://raw.githubusercontent.com/libretro/mame2003-plus-libretro/master/LICENSE.md.

mahoneyt944 commented 7 months ago

@grant2258 @arcadez2003 Compile errors, here's a screenshot of the issue. Screenshot_20240211-111510

https://github.com/libretro/mame2003-plus-libretro/blob/75a6289408554f8d3369eceb2f2816c021725da4/src/drivers/system18.c#L270

grant2258 commented 7 months ago

@mahoneyt944 just change it to return 0xff;. If you can enable ld flags to show unresolved symbols at linking time for the future that would be helpful in the long run.

mahoneyt944 commented 7 months ago

Should be able to do that in the make file, I don't have access to the actual buildbot though.

grant2258 commented 7 months ago

make file is where to do it if you want to fix it is up you will cause less headaches in the long run.