libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
183 stars 109 forks source link

DRZ80 not working #1701

Open wn2000 opened 3 months ago

wn2000 commented 3 months ago

_Originally posted by @wn2000 in https://github.com/libretro/mame2003-plus-libretro/pull/766#discussion_r1545536526_

mahoneyt944 commented 3 months ago

Are you testing this with the current core? This core now has core options to force enable these modes.

mahoneyt944 commented 3 months ago

If you force enable one of these modes, check the info log that it replaced the CPU

https://github.com/libretro/mame2003-plus-libretro/blob/ee777f235b99d652890dedbc94337094968869d4/src/mame2003/mame2003.c#L1693

wn2000 commented 3 months ago

To be clear there are two issues:

  1. The bug on these lines prevents the CPU replacement (as it's comparing a pointer address against an enum):

https://github.com/libretro/mame2003-plus-libretro/blob/ee777f235b99d652890dedbc94337094968869d4/src/mame2003/mame2003.c#L1690

https://github.com/libretro/mame2003-plus-libretro/blob/ee777f235b99d652890dedbc94337094968869d4/src/mame2003/mame2003.c#L1704

  1. After fixing this bug (so the log correctly shows "Replaced Z80"), some sound effects are missing (tested with sdfight before and after the fix). So there's some issue with the original PR that added the DrZ80 support.
mahoneyt944 commented 3 months ago

It's possible the replacement CPU isn't fully compatible as the original. I'd assume this would be a case by case type of thing. Are the replacement cpus working at all after your fix?... to confirm the replaced cpu is operational at least even if buggy?

The core option allows you to replace a main z80 CPU, z80 sound CPU, or both....so there maybe specific combo that works better for some games than others.

wn2000 commented 3 months ago

Yeah so it seems DrZ80 doesn't work at all. Tried 88 games, with Cyclone+DrZ80 it freezes at the ROM OK screen; with Cyclone only it works fine. But Cyclone also has issues. AvP would black screen if Cyclone is enabled.

So, maybe not worth it after all.

arcadez2003 commented 3 months ago

Yeah as i commented at the time they were first supported here the cyclone cpu cores are buggy for a fair few games but boost up the performance of many others hence we turned off the cyclone's by default and make them a toggle option via the menus.

i suppose back in the day a list would have been made as to which games should be played using it and which should not but no one can be bothered with such undertakings nowadays :)

wn2000 commented 3 months ago

Looks like cyclone received some updates recently:

https://github.com/notaz/cyclone68000/commits/master/

grant2258 commented 3 months ago

This was a strange one. I deleted the mame2003 plus folder and done a fresh git clone compiled it and 88 games works. I think the git might be locking or some other odd behavior on the retropie I installed it is old but its the latest on their website. Try deleting your mame source directory and grab it again then recompile. Ive included the retropie bin 4.8 I compiled if you using that.

mame2003_plus_libretro.so.zip