search

libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
183 stars 109 forks source link

Issues from mame menu pause #1735

Closed mahoneyt944 closed 1 month ago

mahoneyt944 commented 1 month ago

when paused for a few seconds audio fails to resume. Fixes on core reset. Seems to be related to the interrupts. lethalen Gijoe

mahoneyt944 commented 1 month ago

Fixed https://github.com/libretro/mame2003-plus-libretro/commit/5f0dff30123f6f891f15a577900ebdc17799d775

mahoneyt944 commented 1 month ago

So lethalen needs this return to work and midres needs this commented out to work. Need to figure out how both can work 😅

https://github.com/libretro/mame2003-plus-libretro/blob/929ebe9e4f18618f5e4e778963eb241859c519dd/src/cpuint.c#L315

arcadez2003 commented 1 month ago

Right i've been busy elsewhere i just scanned the commits so can someone explain what is going on with regards to these core changes which will highly likely result in a ton of game breakage.??

mahoneyt944 commented 1 month ago

Well it started off as fixing "show gfx" which is under the input (general tab), a feature that was stripped and broken. And with the pause like feature added to fix the above, it allowed the core to pause while in the mame menu, which is nice. Unfortunately we're finding this game for that game which doesn't like this pausing. So unless we find a easy workaround I'll have to snip out some of this code. Fortunately though, it can all be disabled by commenting out the calls to cpu_pause(true) so it's not too invasive to revert..just 2 lines of code.

mahoneyt944 commented 1 month ago

https://github.com/libretro/mame2003-plus-libretro/commit/a5646f7531755c6caf2e078447bc8afdd4542767 this should work with everything, I tested about 50 games and it looks good. If you find any games that break, post them here. But I think I got it 😅

mahoneyt944 commented 1 month ago

Also if we are concerned with possible regressions with this we can easily put a core option in to allow pause or not and just put the check in the beginning on cpu_pause and just return if it's disabled which would bypass the whole thing.

arcadez2003 commented 1 month ago

Alright then no worries but the ole rule still applies you break it ya fix it :)

mahoneyt944 commented 1 month ago

Alright then no worries but the ole rule still applies you break it ya fix it :)

That's fair 😅