search

libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
188 stars 108 forks source link

fix frameskip take two #1737

Closed grant2258 closed 4 months ago

grant2258 commented 4 months ago

The variables need set in retro run and there was an if statement I removed but I didnt do a git pull. the frameskip call is requested at least two times a frame so its set in retro run now(some drivers call it as well. The manual frame skips working a lot better now. Ill leave any updates to weekend when I have time to test properly in future.

dont pull this yet I want to test some more things. Ill drop you a wee note here when im done.

grant2258 commented 4 months ago

ok we are good to go aggressive max drops a very few frames. I looked at the low latency there is no point setting it unless you want to increase it it wont let you go lower than the setting in the front end.

grant2258 commented 4 months ago

@mahoneyt944 fixed the interupt pause issue as well.

mahoneyt944 commented 4 months ago

@mahoneyt944 fixed the interupt pause issue as well.

This fixed any issues I found with the interrupt https://github.com/libretro/mame2003-plus-libretro/commit/5f0dff30123f6f891f15a577900ebdc17799d775

Did you find something that failed with that commit still? The driver is still running when paused so event_index was indexing while paused.

grant2258 commented 4 months ago

yes midres fails checked it while i was testing the frameskip on a few games. I left a message in the pull request about. The driver has to keep running inputs are read in the mame loop and not in retrorun. You could try running the user interface as a pause action if all else fails and you keep getting issues.

mahoneyt944 commented 4 months ago

@grant2258 do me a favor and submit the pause fix in a separate PR, I want to bench test it with a boat load of games. Or just remove it here and I'll build a branch with your change

grant2258 commented 4 months ago

just add a .diff when viewing the commit https://github.com/libretro/mame2003-plus-libretro/commit/0f07b78e4de1971050a42ebb815687c8dac3f425.diff if thats an issue using the phone ill put a pull req in for you.

grant2258 commented 4 months ago

separated the two is quicker

mahoneyt944 commented 4 months ago

I copied the changes into a branch, it fixed midres but broke lethalen. So for now just submit the frameskip bits and I'll keep working on the pause. Gonna try something.

mahoneyt944 commented 4 months ago

If you want dump the frame skip update in mame2003 too. I did the part 1 already

grant2258 commented 4 months ago

I need to get to bed for work gluck. lethalen is working fine for me with this. The music stops I see what you mean nasty could also be driver related when interrupts are sketchy as well.

seems to work fine when removing the watchdog reset you added fwiw