search

libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
186 stars 108 forks source link

Soundcore fix #1778

Closed grant2258 closed 1 month ago

grant2258 commented 2 months ago

@mahoneyt944 thats it fixed and hamaways missing sound as well technically you dont even need this update just fix the data range on the core update you done earlier. It will have bugs compared to this one though. I was a ten minute fix to be honest so not really caring what you do with it.

mahoneyt944 commented 2 months ago

Do we need the clock change on system18 too or no? In src/machine/system16_machine.c

grant2258 commented 2 months ago

All the clock that use it need updated they remained the same since mame096u4 (this update) to mame current. You can get the clocks from mame current accept aquario thats on hbmame.

mahoneyt944 commented 2 months ago

I only see the interface in src/machine/system16_machine.c is there another hiding? Or they all using that one?

grant2258 commented 2 months ago

Well to be honest you would need to check with mame current if they are all using the same they are on this core though. Only system18 and segas32 use this sound core part of the reason I wasnt motivated to do it. The clock speed for system18 is 10000000 I doubt aquario will deviate can check hbmame if you think its off.

mahoneyt944 commented 2 months ago

Hmm seems like it's only connected to sys18 and not system16 so maybe it's not that much of an issue. Just use the sys18 clock I guess.