libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
196 stars 110 forks source link

Ninja Baseball Batman "Fix" IRQ/Raster Issues? #1874

Open KMFDManic opened 2 weeks ago

KMFDManic commented 2 weeks ago

@mahoneyt944 @grant2258 @arcadez2003

I am not entirely sure we addressed this before. But, it seems like it should be relatively reasonably feasible to address the slowdown issues present in Ninja Baseball Batman, which appear to be IRQ/Raster Effect related, of which quite a few fixes went into MAME for. Hopefully, the entire driver wouldn't need updated to take advantage of some of these fixes. I always assumed it was just related to protection issues. But, now, seems more so it was slowdown for Raster Effects, and a few other pesky issues, which may be very well possible to fix-up in the 2003 code database...well, hopefully! One can never have enough IREM awesomeness:) Sorry if this has been brought up before. I didn't see much related to it for 2003, in my quick search.

M92 Driver, for Ninja Baseball, which I am certain you all already know:) FBNEO has quite a few fixes, as does MAME.

Bugs:

WIP:

https://github.com/libretro/FBNeo/commits/master/src/burn/drv/irem/d_m92.cpp?after=a8f500c8819bf33cbdb3f038ac1f981290bcfee4+34

Mike Tyson and Jake Paul fight next week on Netflix...Gonna be quite an interesting one to see:)

grant2258 commented 2 weeks ago

I think this only happens at the map screens well I remember it that way in my head.

KMFDManic commented 2 weeks ago

@grant2258 Correct, which appears to be due to Raster Effects at those points. I believe the tilesets are also offset, amongst a few other minor issues. On Lower Spec Platforms, the slowdown at the map junction points can be quite irritating, with how long the game lags for. The fixes appear to be in place for FBNEO, as the Map Loading portions are seamless...But, of course, FBNEO isn't as optimal on Lower Spec for M92 games, unfortunately. Seems like, if we don't actually have to update the driver, itself, could be trivial to just address these hopefully minor to fix conflicts. This could, of course, parlay into fix-ups for a few other games on the same driver.

Hope all is well, by the way!

grant2258 commented 2 weeks ago

Yes all is well am in the middle of possibly changing jobs managed to get a job opportunity in the council. Ill officially be employed by the government if everything works out. We all just need to go where the money is these days, ive not completely made my mind up ive passed the usual background checks ect and its multi stages interviews. If it turns out a better deal ill take it. Hope all is well with yourself as well!

arcadez2003 commented 2 weeks ago

This is the on;y mention of a fix for the raster effects in the MAME WiP when it comes to the game....... https://github.com/arcadez2003/mame/commit/4ffa2901ceed2884ddbb9c5046712427ba3b871f

From memory i looked into adding the fix here but our NEC CPU is totally different so it was hard to pindown for me atleast where in the code to splice it in maybe FBN has an easier to implement fix for this.??

The only other mention on this is an ole post on MAME Testers https://mametesters.org/view.php?id=1060

KMFDManic commented 2 weeks ago

@arcadez2003 Looking at the fixes in FBNEO, some seem to be related to kludge and NCycles and Vez IRQ? Maybe @dinkc64 could shed some light?

arcadez2003 commented 2 weeks ago

Aye he's the man to ask alright so why dont ya :)

dinkc64 commented 2 weeks ago

Heyo arcadez, sorry buddy, I missed ya on ye olde chatter earlier. Damned time change (DST) is messing with me...

Regarding nbbatman: setting up the 8529 pic (programmable interrupt chip) fixed all the problems with nbbatman and got rid of all the kludges regarding messing about with cycles. I recommend doing that, and totally ignore the old kludge-fixes, which were kinda horrible way to do things.

best regards,

dinkc64 commented 2 weeks ago

Addendum: the pic8529 fixes the map screen issue a slight overclocking (9.96mhz) will help with the raster effects

arcadez2003 commented 2 weeks ago

That's for the advice @dinkc64 i'll pop on the chat tomorrow and BTW i came on the say hello not to bug ya for a fix here as i felt it was @KMFDManic who should ask since he dropped your name into this conversation :)

KMFDManic commented 2 weeks ago

@dinkc64 Much appreciated, your feedback. Was a pleasure collaborating with ya in the past on Coleco Stuff:) I have been keeping up on all the commits you've done on FBNEO, and Arcade Perfection comes with both FBNEO/2003 Plus Combos, to pretty much cover all the bases:) No need for "Current" MAME, haha:)