libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
190 stars 108 forks source link

testers needed for new Data East games #215

Closed ghost closed 6 years ago

ghost commented 6 years ago

I've just updated a few things in the core which nets us some more playable Data East games i have tested all the newly supported games and previously supported games which are affected by this and they all pass with flying colours

Two however escaped me due to memory limitations with my xbox test core, and im keen to know if they're actually playable and with regards to Skull Fang to see what fps you get.

Avengers In Galactic Storm Backfire! Skull Fang (Just a performance check)

ghost commented 6 years ago

you want this tested on a pc or the raspberry pi @arcadez

ghost commented 6 years ago

Whatever folks are using really

ghost commented 6 years ago

There's a question mark over Avengers In Galactic Storm as im not sure if i have to to make some changes in the SH2 cpu for that one, as for Backfire! some folks reported they could not add coins or control the game the change to the ARM CPU should sort this.

Skull Fang i know it works but im just keen to know what fps folks are getting with it

ghost commented 6 years ago

Topical point Skull Fang is the last game in a trilogy for those that dont know.....

Vapor Trail - Hyper Offence Formation (1989) Rohga Armor Force (1991) Skull Fang (1996)

I thought it better to have em all for this core :)

ghost commented 6 years ago

ok ill compile on pc and pi and get the romsets built ill get back to you mate.

Another off topic point i was using robocop on fba alpha and reported asked on the pi forums if it was running bad for anyone(i meant slow). The subject changed to fba was better because robocop has sounds when you put credits in. It was unrelated but we are missing credit sounds in robocop

ghost commented 6 years ago

sorry i was so long was playing skullfang love it full 58 fps on my i7 @arcadez ill hey the other 2

ghost commented 6 years ago

Nice one hopefully it wont drop framerate too much on the Rpi or similar hardware i only get 20 to 25fps on the ole xbox but the game is perfectly playble none the less

ghost commented 6 years ago

ok there is a problem with Avengers In Galactic Storm there are no dip switches and the screen is disaplaying this. Im guessing we need a nvram. but need the service menu in the dipswithes to make one.

avengrgs-180519-233809

ghost commented 6 years ago

backfire inputs are working for me again no dipswitches bit its playable! ill test framerates on the pi now.

backfire-180519-234346

ps this game reminds me of neo drift out!

ghost commented 6 years ago

be back in a but with Skull Fang on the rasp pi 2+b not the fastest pie hopefully someone with i p 3+b will report as well

ghost commented 6 years ago

These games have virtual dips to access em you have to bring up the remap this game options look for service mode then asign it a button once you press the button they should pop up.

I added a nvram file to the romload table this worked with Skull Fang and the Hoops games but maybe the driver wasn't setup to use the nvram for Avengers at this point in the MAME dev cycle.

The nvram is setup as an optional load try removing it from the rom then delete avengrgs.cfg and nvram then boot the game once more you'll have to do the above with the service mode to get it to work though from memory all you have to do is enter and then exit the service mode then the game will startup

markwkidd commented 6 years ago

The Avengers in Galactic Storm romset does have an nvram file as part of its mame 0.139 romset. I can add this nvram to the bootstraps in a bit to see what happens

On Sat, May 19, 2018 at 5:41 PM, grant2258 notifications@github.com wrote:

ok there is a problem with Avengers In Galactic Storm there are no dip switches and the screen is disaplaying this. Im guessing we need a nvram. but need the service menu in the dipswithes to make one.

[image: avengrgs-180519-233809] https://user-images.githubusercontent.com/6128601/40273727-15c432d6-5bbe-11e8-84b6-b481d95f9d3b.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/215#issuecomment-390437372, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdvDSMrjAcXqxfkwKL-Qfw__wpH7dks5t0J9_gaJpZM4UF2rL .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

ghost commented 6 years ago

need to do a clean compile on the pi getting a black screen on skull fang on the pi will recompile from scratch and report back

ghost commented 6 years ago

Yeah that happens unless you have the latest ARM CPU from the core

ghost commented 6 years ago

yea ive been messing with the code on the pie as well will just do a clean compile mate so everythign is as it should be. Will be about 20 minutes to compile

ghost commented 6 years ago

@markwkidd i already added a bootstarp so to speak but im thinking the driver might not be correctly setup to use it in the romload.....

ROM_REGION( 0x80, REGION_USER1, ROMREGION_ERASE00 )
ROM_LOAD_OPTIONAL( "avengrgs.nv",  0x00, 0x80, CRC(c0e84b4e) SHA1(e7afca68cc5fa69ded32bc0a1dcc6a59fe7f081b) )

ROM_END

It's optional though so if it's removed from the avengrgs rom then the game will boot without it but will then need setup via the service mode, a quick delete of the previous cfg and nvram for this game will let me know if the problem is via the nvram or maybe i need to then check the SH2 CPU we have in this core is correct for the game to work

ghost commented 6 years ago

maybe marks nvram code is changing something not sure ill try the service mode it tricky now you cant reset from the tab menu i forget the reset key for retroach lol.

ghost commented 6 years ago

Skull Fang [libretro INFO] [MAME 2003+] Allocated 80 bytes @ 145E7230 [libretro INFO] [MAME 2003+] Opening ROM file: avengrgs.nv [libretro INFO] [MAME 2003+] Loading ROM data: offs=0 len=80 mask=FF group=1 skip=0 reverse=0 [libretro INFO] [MAME 2003+] Verifying length (80) and checksums [libretro INFO] [MAME 2003+] Verify finished

i definatly loading arcadez

ghost commented 6 years ago

@markwkidd could you bootstrap code be over riding this ?

ghost commented 6 years ago

mame 078 doesnt have a service mode per say its usually set in the dipswitches arcadez

INPUT_PORTS_START( aburner ) PORT_START / player 1 / PORT_BIT( 0x01, IP_ACTIVE_LOW, IPT_BUTTON3 ) / unknown / PORT_BITX(0x02, IP_ACTIVE_LOW, IPT_SERVICE, DEF_STR( Service_Mode ), KEYCODE_F2, IP_JOY_NONE )

the ui doesnt have a universal map for this in mame078 every driver seems to do it like this

ghost commented 6 years ago

lemmie check the game in my other Xbox MAME core to see how the service mode is activated

ghost commented 6 years ago

there i sonly service 1 2 3 4 tried them all none are doing anything

markwkidd commented 6 years ago

No the bootstrap code only drops in a nvram file if the game is listed as needing one in mame.c which this isn't yet. my code only operates in the file handling code so I didn't need to touch anything about nvram processing or service mode

On Sat, May 19, 2018, 6:11 PM grant2258 notifications@github.com wrote:

@markwkidd https://github.com/markwkidd could you bootstrap code be over riding this ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/215#issuecomment-390438670, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdkKHcFU6ZP1946xL54Dc6G0SDEknks5t0Ka3gaJpZM4UF2rL .

ghost commented 6 years ago

@arcadez for cps2 in the driver INPUT_PORTS_START( 19xx ) PORT_START / IN0 (0x00) / PORT_BIT( 0x0001, IP_ACTIVE_LOW, IPT_JOYSTICK_RIGHT | IPF_8WAY | IPF_PLAYER1 ) PORT_BIT( 0x0002, IP_ACTIVE_LOW, IPT_JOYSTICK_LEFT | IPF_8WAY | IPF_PLAYER1 ) PORT_BIT( 0x0004, IP_ACTIVE_LOW, IPT_JOYSTICK_DOWN | IPF_8WAY | IPF_PLAYER1 ) PORT_BIT( 0x0008, IP_ACTIVE_LOW, IPT_JOYSTICK_UP | IPF_8WAY | IPF_PLAYER1 ) PORT_BIT( 0x0010, IP_ACTIVE_LOW, IPT_BUTTON1 | IPF_PLAYER1 ) PORT_BIT( 0x0020, IP_ACTIVE_LOW, IPT_BUTTON2 | IPF_PLAYER1 ) PORT_BIT( 0x0040, IP_ACTIVE_LOW, IPT_UNKNOWN ) PORT_BIT( 0x0080, IP_ACTIVE_LOW, IPT_UNKNOWN ) PORT_BIT( 0x0100, IP_ACTIVE_LOW, IPT_JOYSTICK_RIGHT | IPF_8WAY | IPF_PLAYER2 ) PORT_BIT( 0x0200, IP_ACTIVE_LOW, IPT_JOYSTICK_LEFT | IPF_8WAY | IPF_PLAYER2 ) PORT_BIT( 0x0400, IP_ACTIVE_LOW, IPT_JOYSTICK_DOWN | IPF_8WAY | IPF_PLAYER2 ) PORT_BIT( 0x0800, IP_ACTIVE_LOW, IPT_JOYSTICK_UP | IPF_8WAY | IPF_PLAYER2 ) PORT_BIT( 0x1000, IP_ACTIVE_LOW, IPT_BUTTON1 | IPF_PLAYER2 ) PORT_BIT( 0x2000, IP_ACTIVE_LOW, IPT_BUTTON2 | IPF_PLAYER2 ) PORT_BIT( 0x4000, IP_ACTIVE_LOW, IPT_UNKNOWN ) PORT_BIT( 0x8000, IP_ACTIVE_LOW, IPT_UNKNOWN )

PORT_START      /* IN1 (0x10) */
PORT_BIT( 0x0001, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0002, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0004, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0008, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0010, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0020, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0040, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0080, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0xff00, IP_ACTIVE_LOW, IPT_UNKNOWN )

PORT_START      /* IN2 (0x20) */
PORT_BIT( 0x0001, IP_ACTIVE_LOW, IPT_SPECIAL )   /* EEPROM bit */
PORT_BITX(0x0002, IP_ACTIVE_LOW, IPT_SERVICE, DEF_STR( Service_Mode ), KEYCODE_F2, IP_JOY_NONE )
PORT_BIT( 0x0004, IP_ACTIVE_LOW, IPT_SERVICE1 )
PORT_BIT( 0x00f8, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0100, IP_ACTIVE_LOW, IPT_START1 )
PORT_BIT( 0x0200, IP_ACTIVE_LOW, IPT_START2 )
PORT_BIT( 0x0400, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x0800, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x1000, IP_ACTIVE_LOW, IPT_COIN1 )
PORT_BIT( 0x2000, IP_ACTIVE_LOW, IPT_COIN2 )
PORT_BIT( 0x4000, IP_ACTIVE_LOW, IPT_UNKNOWN )
PORT_BIT( 0x8000, IP_ACTIVE_LOW, IPT_UNKNOWN )

INPUT_PORTS_END

ghost commented 6 years ago

probably a mame078 thing

ghost commented 6 years ago

Right service 1-4 are in the general input options, we want input this game options were you will find service_mode

ghost commented 6 years ago

anyway ot might be quicker to just delete your cfg and nvram for this game and i'll disable the nvram in the driver then @markwkidd can give the game a bootstrap instead

markwkidd commented 6 years ago

I removed the nvram file from the mame 0.139 romset and then loaded the modified romset in mame 0.139

It starts up fine that way without the glitches. I'll try using our bootstrap system but I'm thinking maybe its not nvram related

ghost commented 6 years ago

@arcadez f2 is set as service mode nothign is happening i wonder is this is the mame gfx view screen. Im pretty sure that has been hacked out of mame2003 though so you cant turn it on and off

ghost commented 6 years ago

Yeah on the xbox we highlight it press a then assign it another button and when you press it in game up pops the service mode which contains the virtual dips for the game similar to what you get in the older style dips that most games use

markwkidd commented 6 years ago

My mistake -- actually you do have problems if you remove the nvram from mame 0.139.

Adding the nvram as a bootstrap cleared up a lot of the video glitches but there is now clearly visible the problem that @grant2258 noticed -- the mame gfx screen is up by default

Edit: No it's not the MAME Gfx screen although it looks like it. it's like the character set. Let me push a commit so you all can see what I'm seeing

ghost commented 6 years ago

For example in Avengers i get.......

Game Options Sound Options Coin Options I/O Options Versus Options Story Options Screen Options Screen Check Color Check Initial Game Mode

ghost commented 6 years ago

@markwkidd in the original driver i ported the only game with the nvram setup was Skull Fang i added the rest for ease of use for the users the Hoop's games are fine but Avengers maybe not.

I dont think we need it as it looks fine without the nvram im playing it now on the xbox

ghost commented 6 years ago

@markwkidd thats a core issue if is ineede the gfx screen showing. might need to add the key to toggle this on and off back in

ghost commented 6 years ago

its could also be 64 bit issues ill get back to you after its compiled on the the pie

markwkidd commented 6 years ago

yeah it's starting to seem like an issue in the mame2003 core

On Sat, May 19, 2018 at 6:45 PM, grant2258 notifications@github.com wrote:

@markwkidd https://github.com/markwkidd thats a core issue if is ineede the gfx screen showing

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/215#issuecomment-390440846, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdokukWq44jK2-0aGXQIYhTbWgORlks5t0K6BgaJpZM4UF2rL .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

ghost commented 6 years ago

its doing the same thing on the pi as well @arcadez on a pi2+b not overclocked skull is runing at 37.fps will be better on a pi 3+b though hopefully someone reports the bug.

something isint right with avengers its either core or something we are missing can you vie the gfx and see if that matched the screen shot @arcadez that option has been ripped out of this core not sure why

markwkidd commented 6 years ago

you can still display the gfx in mame2003-plus. map it to a button in the MAME menu. it is not the same as what is showing

ghost commented 6 years ago

i get the feeling its because we changed the order of this structure i wish people would just set it not set anything here instead of messing the structure up.

struct ipd inputport_defaults[] =

im going to put the default one back in and test

ghost commented 6 years ago

actually there is no point in doing tht its been hacked everywhere even in drivers

markwkidd commented 6 years ago

I can't see how changing the default input mappings would cause this problem, but also I can't see why it would be hard to put back in the original ones to test. It's a straightforward structure.

inputs in the drivers are mapped by name to inputs in inptport -- it doesn't even matter what order they're in except for saving the .cfg file

On Sat, May 19, 2018 at 7:08 PM, grant2258 notifications@github.com wrote:

actually there is no point in doing tht its been hacked everywhere

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/215#issuecomment-390442441, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdoftCV98YhvPPgBf4cdn1wTSaRCyks5t0LPggaJpZM4UF2rL .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

ghost commented 6 years ago

we need to confirm its the mame gfx screen first before hunting. I did try deleting the cfg files didnt help. We will just need to try find out whats going on it might not be the mame gfx screen. I have to redo my default.cfg everytime this structure changes

markwkidd commented 6 years ago

It's definitely not the mame GFX screen.

Map MAME GFX to a button in your MAME menu in mame2003-plus then you can see MAME GFX

On Sat, May 19, 2018 at 7:12 PM, grant2258 notifications@github.com wrote:

we need to confirm its the mame gfx screen first before hunting. I did try deleting the cfg files didnt help. We will just need to try find out whats going on it might not be the mame gfx screen

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/215#issuecomment-390442654, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdnLRAdXtx9eumysCPW7VBRJYpw9Gks5t0LUHgaJpZM4UF2rL .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

markwkidd commented 6 years ago

screenshot 2018-05-19 19 14 53

markwkidd commented 6 years ago

This is what the GFX screen looks like in avengrgs

screenshot 2018-05-19 19 15 46

ghost commented 6 years ago

toggle through the screens

ghost commented 6 years ago

im ging to test this on latest mame in the service mode and the show gfx see if we can replicate it with settings from wother

markwkidd commented 6 years ago

That is the only screen that displays if I press the Gfx button :man_shrugging:

markwkidd commented 6 years ago

I'm going to try it in mame 0.139

ghost commented 6 years ago

http://wiki.mamedev.org/index.php/Using_the_GFX/TileMap_viewer_(F4)