search

libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
189 stars 108 forks source link

support for any other hacked, homebrew, or decrypted neogeo romsets #476

Closed markwkidd closed 4 years ago

markwkidd commented 5 years ago

This is a continuation of the King of Fighters 2003 conversation.

Compared to @arcadez and @grant2258 I don't know much about Neo Geo. That is why I have a feeling I am about to be closing this issue again pretty quickly.

However after following the kof2003d discussion I tried to at least learn a little about decrypted Neo Geo romsets. I've been looking at mameplus source code and I see that there homebrews, decryptions, bootlegs, and hacks that were not added to regular MAME.

Are any of these other romsets that would be possible to add and worth adding?

ghost commented 5 years ago

Anything added after around MAME 100 or so is going to be problematic due to big Neogeo core changes thats to say the graphical sound and protection code will be different, that's not to say it cant be done.

The question you have to ask yourself is bootlegs and hacks of games we already support worth the hastle and workload you would be taking on.?? as for the hacks alotta them are unfinished only having a level or 2 NeoPong is decent though and fun in 2 player you could drop that in without too much grief i can send ya the code sometime if you want.

markwkidd commented 5 years ago

I wish I could find source for older versions of mameplus than 0.135 -- that sounds more relevant.

I definitely don't want to add junk for the sake of having a longer gamelist.

I watched a video of Neo Pong and it looks at least fully functional as far as Pong goes. I'm not surprised that you've actually played it! Is it actually fun? Then maybe .. :)

On Fri, Nov 9, 2018 at 3:42 PM arcadez notifications@github.com wrote:

Anything added after around MAME 100 or so is going to be problematic due to big Neogeo core changes thats to say the graphical sound and protection code will be different, that's not to say it cant be done.

The question you have to ask yourself is bootlegs and hacks of games we already support worth the hastle and workload you would be taking on.?? as for the hacks alotta them are unfinished only having a level or 2 NeoPong is decent though and fun in 2 player you could drop that in without too much grief i can send ya the code sometime if you want.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/476#issuecomment-437529775, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdoE2hhxaqgednVXkQsWFny8Nj4gmks5uthLMgaJpZM4YXh-Z .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

markwkidd commented 5 years ago

OK, I guess I did find the mameplus 0.100u1 source: https://github.com/svn2github/mameplus/tree/2d02d80352ff0b695441a1aa457c872fb39c592a

This neogeo.c does indeed look more like ours. Here is the start of the driver declarations: https://github.com/svn2github/mameplus/blob/2d02d80352ff0b695441a1aa457c872fb39c592a/mamep/src/drivers/neogeo.c#L7358

They have a much more concise section referred to as EXTRA_GAMES which I guess is what we would be looking at:

#ifdef EXTRA_GAMES
/* homebrew */
GAMEBX(1989, beast,    neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "Psygnosis", "Shadow of the Beast (Neo Demo)", GAME_NOT_WORKING )
GAMEBX(1990, columnsn, neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "Sega", "Columns (Neo-Geo)", GAME_NOT_WORKING )
GAMEB( 1994, diggerma, neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "Unknown", "Digger Man" )
GAMEBX(200?, poknight, neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "JMK", "Poker Night", GAME_NO_SOUND )
GAMEB( 2002, neonopon, neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "Blastar", "Neo No Panepon (beta)" )
GAMEB( 2002, neopong,  neogeo,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "Neodev", "Neo Pong (v1.1)" )
GAMEB( 2002, npong10,  neopong,  neogeo, neogeo, neogeo,  neogeo,   ROT0, "Neodev", "Neo Pong (v1.0)" )

/* Decrypted sets. These are hacks or bootleggs */
GAMEB( 1999, kof99nd,  kof99,    neogeo, raster, neogeo,  sfixdec,  ROT0, "SNK", "The King of Fighters '99 - Millennium Battle (non encrypted P,decrypted C)" )
GAMEB( 1999, garoud,   garou,    neogeo, ras320, neogeo,  garoud,   ROT0, "SNK", "Garou - Mark of the Wolves (decrypted C)" )
GAMEB( 2000, mslug3nd, mslug3,   neogeo, raster, neogeo,  mslug3nd, ROT0, "SNK", "Metal Slug 3 (non encrypted P,decrypted C)" )
GAMEB( 2000, kof2000d, kof2000,  neogeo, neogeo, neogeo,  kof2000d, ROT0, "SNK", "The King of Fighters 2000 (non encrypted P,decrypted C)" )
GAMEB( 2001, zupapad,  zupapa,   neogeo, neogeo, neogeo,  neogeo,   ROT0, "SNK", "Zupapa! (custom decrypted C)" )
GAMEB( 2001, sengok3d, sengoku3, neogeo, neo320, neogeo,  sfixdec,  ROT0, "SNK", "Sengoku 3 / Sengoku Legends 2001 (decrypted P,decrypted C)" )
GAMEB( 2000, nitdd,    nitd,     neogeo, neo320, neogeo,  sfixdec,  ROT0, "Eleven / Gavaking", "Nightmare in the Dark (decrypted C)" )
GAMEB( 1999, s1945pd,  s1945p,   neogeo, neo320, neogeo,  sfixdec,   ROT0, "Psikyo", "Strikers 1945 Plus (decrypted C)" )
GAMEB( 1999, ganryud,  ganryu,   neogeo, neogeo, neogeo,  sfixdec,   ROT0, "Visco", "Musashi Ganryuuki (decrypted C)" )
GAMEB( 1999, preisl2d, preisle2, neogeo, neogeo, neogeo,  sfixdec,  ROT0, "Yumekobo", "Prehistoric Isle 2 (decrypted C)" )
#endif /* EXTRA_GAMES */
markwkidd commented 5 years ago

So if I'm understanding what is already supported, we're really looking at a pool that includes:

ghost commented 5 years ago

If you look at the homebrew decs above you'll see they hang off the standard neogeo code so all you'd need to do is add the roms then declare em in the driver and driver.c, as for hacks n bootlegs they may need additional protection or decryption code.which you would need to backport.

ghost commented 5 years ago

I really think you should spawn another fork if you want hacks or homebrew unless there is a good reason to add one in particular again its up to you guys.

ghost commented 5 years ago

Im in agreement hence im trying to put off @markwkidd from adding these by menting to workload required :) there is one however im considering adding a hack by trap15 which removes all the slowdown in Metal Slug 2...........

http://daifukkat.su/blog/archives/2015/03/30/its_turbo_time/

Wilstorm commented 5 years ago

@arcadez - I read through it and those types of hacks just seem sensible and beneficial really. Improving game performance is a win-win or do some prefer the originals with all the caveats.

markwkidd commented 5 years ago

Yeah I'm curious if any of these homebrews have gameplay worth bothering with. For me I'm honestly more interested in something weird and unpublished than speed fixes but to each their own. I haven't had time to more than look at their attract mode videos yet. :)

If something is not really a game, or it's boring, I don't want to bother just for the sake of increasing the total count.

On Sat, Nov 10, 2018 at 8:18 AM Wilstorm notifications@github.com wrote:

@arcadez https://github.com/arcadez - I read through it and those types of hacks just seem sensible and beneficial really. Improving game performance is a win-win or do some prefer the originals with all the caveats.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/476#issuecomment-437595224, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdqAlMYnL-AYj5-diTqlH-rWGM8N2ks5utvw4gaJpZM4YXh-Z .

-- Mark W. Kidd http://facebook.com/markwkidd (606)536-0115

ghost commented 5 years ago

Well if you like Metal Slug 2 which alotta folks do myself included then you'd appreciate it not slowing down to a crawl at certain points during every level, we'll agree to disagree on this as fanboy hacks that add a different coloured t-shirt to the characters or incomplete homebrew games are not my cup of tea :)

Wilstorm commented 5 years ago

I do think there's some incredible home brew stuff that is great but this doesn't feel so much like a hack but more of a performance correction getting rid of the slowdowns making the game run like it should have from the get go. I have all the Metal Slug games in my library. What Plus doesn't support I run in FBA.

markwkidd commented 5 years ago

Seems like we should definitely add the hacked mslug2 romset!

On Sun, Nov 11, 2018, 8:02 AM Wilstorm <notifications@github.com wrote:

I do think there's some incredible home brew stuff that is great but this doesn't feel so much like a hack but more of a performance correction getting rid of the slowdowns making the game run like it should have from the get go. I have all the Metal Slug games in my library. What Plus doesn't support I run in FBA.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/mame2003-plus-libretro/issues/476#issuecomment-437682228, or mute the thread https://github.com/notifications/unsubscribe-auth/ASphdumULcOQeNHuNsjMVqXBshBCxFUOks5uuEowgaJpZM4YXh-Z .

ghost commented 5 years ago

let me try clear up what I mean. Changing pacman character to a sausage dog is just a gimmick. Something that add functionality or fix bugs are a no brainers just do it.

Just changing a tune or gfx hmmm not so much unless its a big change and is well received in general/ What i like about the ost additions we put it is its completely optional by the user. The fact i dont really use this core probably means I should keep my opinions to myself and shut up :)

mahoneyt944 commented 4 years ago

@markwkidd safe to close? A lot of neogeo games are now supported.

markwkidd commented 4 years ago

Sounds good to me