libretro / mame2003-plus-libretro

Updated 2018 version of MAME (0.78) for libretro. with added game support plus many fixes and improvements
Other
192 stars 110 forks source link

new retropie forum thread #92

Closed markwkidd closed 6 years ago

markwkidd commented 6 years ago

Hello all. The retropie forum thread now is great, but I noticed that there are more than 460 posts! There is some misunderstandings about the relationship between the two cores which are based on the title of the thread and the early posts. Just one example of how it's out of date.

@Wilstorm or someone else, would you be willing to start a new thread with a title that includes the word "mame2003-plus"?

It could be anything. "mame2003-plus: brave new core (testers needed)", "mame2003-plus: brilliant advances and broken builds (testers needed)", "mame2003-plus: what does god need with a starship?"

Sometimes it's awkward for me to post a thread like this in the RetroPie forum when people realize I don't personally have/use RetroPie, just RetroArch.

If such a new thread exists, I'll immediately be on hand as with the existing thread.

markwkidd commented 6 years ago

One thing I'm thinking is that the core is probably ready for even more testing and testers. Especially with RetroPie 4.4 just out, this seems like a good moment to welcome a few more to the mystery.

Wilstorm commented 6 years ago

lol...personally I like what does god need with a starship! Something ummm...less majestic would be fine though too! I don't think anyone would mind that you're not using RetroPie. My only thought is if you're the thread starter it would allow any pertinent or important information to be posted in the first thread that can be updated or added later as needed. Or refer people to the top of the thread for useful information.

ghost commented 6 years ago

@Wilstorm your great with people on the forum though you go out your way to help out ect not many do that

Wilstorm commented 6 years ago

I agree it's a runaway thread. I would be intimidated to sift hours through pages of information looking for an answer plus I am not sure what happened to darknoir (OP)...we've lost control of the thread!

dankcushions commented 6 years ago

could steal the formatting of my old mame2003 development thread: https://retropie.org.uk/forum/topic/2889/mame-development-lr-mame2003-updates :)

Wilstorm commented 6 years ago

@grant2258 that is very kind of you...was that a butter job? ;) To be honest I am a cheerleader on the sidelines rooting for my favorite team because you guys are saving me a LOT of quarters! Honestly...honestly the work you guys do is incredible and I could never say thank you enough for the gift of retro gaming in my living room.

@dankcushions - I like that format and always found it incredibly helpful and easy to follow.

Wilstorm commented 6 years ago

@markwkidd - Hey Mark, you had one of those evenings getting up in the middle of the night to fix something? Having a eureka moment of clarity and the next day damn I'm tired! ;) If I get a solid 6 I am ok, If it's restless sleep a bit longer.

I can start a thread if no one else will as I know you guys stay busy with programming. I think having anyone test anything or even their favorites is all beneficial to uncovering even minute errors. I've been working my way through my favorites list which is roughly 330 or so games which seems minuscule compared to the whole set but if the parent or clone runs from a set it probably a pretty good sign. What do you think would be a good title that you will be ok looking at months later. ;) Also what section "Ideas and Development"?

markwkidd commented 6 years ago

It's a classic moment when I suggest to someone else to start a retropie thread and then I break the retropie setup script.

@Wilstorm I see that @dankcushions put their mame2003 development thread in "Ideas and Development" so that does seem like the right spot.

Wilstorm commented 6 years ago

It's a classic moment when I suggest to someone else to start a retropie thread and then I break the retropie setup script.

I thought of that from Zappa's thread and figured it better compile correctly before doing anything. There's only one option in RetroPie and that's update from source!

Wilstorm commented 6 years ago

RetroPie has 2 options usually 'update from binary' or 'update from source'. I don't fully understand how it works why a binary update isn't available or does that come later once out of experimental.

dankcushions commented 6 years ago

the binary is when jools adds it to his buildbot. he won't do that until it leaves 'experimental' which is going to be hard ask until it builds successfully for a few days in a row ;) i wouldn't worry about it, given that we're in active development it will be out of date hours after the binaries are built, and they don't tend to get rebuilt until the next retropie release.

the libretro buildbot may have rpi builds though, maybe?

markwkidd commented 6 years ago

I wonder if binaries from this section of the buildbot would work with an rpi. Anyone care to try? https://buildbot.libretro.com/nightly/linux/armhf/

markwkidd commented 6 years ago

@Wilstorm & others -- I don't have any more big refactoring or library updates on the agenda.

I'd like to eventually use more of the libretro-common/file_path functions to handle file paths, now that the library is available, but there's nothing coming from me soon that's especially likely to screw up the buildbot or RetroPie-Setup. Knock on wood.

Once the RetroPie PR is approved, or improved and replaced, then knock on wood, it should be a good time for more people to start using and testing the core.

ghost commented 6 years ago

ive complied and installed mame2003 its fine had an error on the retroarch config that was a problem with mame itself though(older version I mean). Im compiling mame 2003+ now ill let you know how i get on and if its all good. I am going to learn to type one day.

Wilstorm commented 6 years ago

and they don't tend to get rebuilt until the next retropie release.

That makes sense now. I swear certain games worked for a long time and then didn't after a rebuild and I updated from binary and still a no go but after a source update all worked again. So that binary can be months old before being updated.

I am going to learn to type one day.

Remember fingers on a s d f (left hand) and j k l ; (right hand)...you got this!

ghost commented 6 years ago

@markwkidd

ok mame2003 is building again when jools accepts that script we have a little problem though mark not a big one

‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/mame2003-plus_libretro.so’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/mame2003-plus_libretro.so’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/README.md’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/README.md’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/CHANGELOG.md’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/CHANGELOG.md’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/catver.ini’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/catver.ini’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/cheat.dat’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/cheat.dat’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/hiscore.dat’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/hiscore.dat’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/mame2003.xml’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/mame2003.xml’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/nvram’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram/bubblem.nv’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/nvram/bubblem.nv’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram/rungun.nv’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/metadata/nvram/rungun.nv’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/nvram’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram/bubblem.nv’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/nvram/bubblem.nv’ ‘/home/pi/RetroPie-Setup/tmp/build/lr-mame2003-plus/metadata/nvram/rungun.nv’ -> ‘/opt/retropie/libretrocores/lr-mame2003-plus/nvram/rungun.nv’ /home/pi/RetroPie-Setup

the script looking for the ram to be in /libretrocores/lr-mame2003-plus/nvram/

there are in there the rest are in metadata when need then in one place. the script will need updating if the path changes

ghost commented 6 years ago

@Wilstorm if you want to build the latest mame source for test you can download the script to retropie in retro pie with wet https://github.com/grant2258/mame2003-plus-libretro/raw/master/lr-mame2003.sh

chmod +x lr-mame2003.sh

this will fix mame and mame 2003

Wilstorm commented 6 years ago

Ok I grabbed the script. Do an update from source and run the script afterwards?

ghost commented 6 years ago

you do the script first this is what builld sources uses

go this

cd /home/pi/RetroPie-Setup/ wet https://github.com/grant2258/mame2003-plus-libretro/raw/master/lr-mame2003.sh chmod +x lr-mame2003.sh sudo cp lr-mame2003.sh scriptmodules/libretrocores/

then just install how you normally install your source

if you update the script youll need to do it again but it will get you compiling until the pull request is accepted or denied

Wilstorm commented 6 years ago

@grant2258 - Oh, nice, thank you for the instructions, that's really handy!

markwkidd commented 6 years ago

Is anyone in a position to test out the XML generator again and make sure it's producing valid XML that won't make ClrMamePro go haywire? I've visually inspected its output and things look right now but I'm worried.

ghost commented 6 years ago

let me check of there has been any updates since i compiled last night mark mame2003 or 2003+ ?

Wilstorm commented 6 years ago

Have the new changes been accepted or still waiting?

markwkidd commented 6 years ago

Still waiting. @Wilstorm you can subscribe to that PR on the right side of the screen at this link if you want an email when there is activity: https://github.com/RetroPie/RetroPie-Setup/pull/2375

markwkidd commented 6 years ago

@grant2258 the big update is hack CD soundtrack support for Final Fight, Mortal Kombat, and NBA Jam if you hadn't seen that. Comes to us via twinaphex from @KMFDManic in the SNES Classic mod scene.

ghost commented 6 years ago

well that in itself justifies the update!

Wilstorm commented 6 years ago

Thank you and subscribed.

ghost commented 6 years ago

@markwkidd mark there is still the issue with the nvram dir and one in metatdata as well the script is using nvram

ghost commented 6 years ago

@markwkidd ive fixed the script up made a few minor changes for nvram if you could add these changed to you commit on retropie/ scripts at the same place on my repo.

KMFDManic commented 6 years ago

TEST Video of Final Fight with Sega CD OST, Mortal Kombat with Custom OST, and NBA Jam with Sega CD OST. I already Pull Requested the Final Fight into MAME 2003 Plus. Looks like @twinaphex got the other 2 merged:) I mostly work with NES and SNES Classic. But, everything works fine on the PC side of things, as well.

SNES Classic - NBA Jam Arcade with SEGA-CD OST!!! The Trifecta of OST Perfection!!!

https://www.youtube.com/watch?v=VW_ompmEsEE

I have all the necessary Samples Available, too. They are all posted in my Core Set, in Xtras/Arcade Folder. Thanks @markwkidd, and all the rest of you, for having me involved in one of my personal favorite Cores:)

https://github.com/KMFDManic/NESC-SNESC-Modifications/releases

markwkidd commented 6 years ago

@grant2258 thanks for looking at the retropie script again -- I have submitted your updates to my retropie PR

@KMFDManic welcome welcome welcome!

ghost commented 6 years ago

@KMFDManic Welcome aboard nice to see you here!

markwkidd commented 6 years ago

I think mame2003-plus is now good to go for RetroPie once users update RetroPie Setup

Wilstorm commented 6 years ago

@grant2258 - After Buzz rolled back I can't update my RetroPie script. I know you said 'til it changes. What do I need to do to get it working again? Here's a screenshot of the error:

capture

ghost commented 6 years ago

cd /home/pi/Retropie-Setup sudo git stash

Wilstorm commented 6 years ago

@grant2258 - Thank you good sir! :)

ghost commented 6 years ago

mark he rejected it completely nothing changed . Maybe he will add the nvram i done a fix for daphne as well and it wasnt accepted. Im not sure what you have to do to get changes done on retropie. To be fair i was learning github at the time and made a major mess of my pull requests so i just put the pull request in its still open.

https://github.com/RetroPie/daphne-emu/pull/15

markwkidd commented 6 years ago

joolswills took out the nvram part altogether by mistake but looking at lr-mame2003.sh right now I think it's got everything it needs to install. the nvram folder isn't essential although it will be nice to get back.

jools said he would put nvram back himself -- probably tired of me sending PRs

ghost commented 6 years ago

Ii did answer his questions though so there is some clarification

KMFDManic commented 6 years ago

@grant2258 Can you let me know exactly which Commits helped fix Midway Bally Games? I would like to add them to my own personal Build. In the end, I would like to be in synch with the latest MAME 2003-Plus. But, there are still a few conflicts to sort out on our end. Excellent work, and it is a true blessing to finally be able to run them! I tested them out, and they were running impeccably well!

@markwkidd As far as info on the OST Customs, you can view the ReadMe files for each of the 3, inside my Xtras/Arcade Folder:) Let me know if you have any other specific questions. These were done this way, due to what performs best on the Mini NES/SNES:)

@hunterk Props for the Canoe Borders, I added them, since I am running NESC/SNESC, after all:)

ghost commented 6 years ago

@KMFDManic i have two fixes one for mame2003-plus that does game timing properly

and i dont want to mess with mame2003 so the music plays a little faster when the fps is lower than 60 30 fps isint effected which one would you like?

ghost commented 6 years ago

my latest one for mame2003 plus is here https://github.com/libretro/mame2003-plus-libretro/pull/94 mame2003 https://github.com/libretro/mame2003-libretro/pull/359/commits

dankcushions said he is working on something to accomadate both but if you loose the sound timing there is no code in mame2003 to stop a game running too fast thats why i didnt use a buffer

KMFDManic commented 6 years ago

@grant2258 I can test both. Main concern is retaining Data East and Irem encryption fixes, as well as the 3 Custom OSTs I added. Much appreciated. I know this was a challenge for awhile. Whatever I need to add, code wise, to test, recommend away. Hopefully, you had a chance to try our custom Final Fight Sega CD OST:)

ghost commented 6 years ago

i will indeed i think i have the cd about somewhere but ill just download them the cd is probably unreadable after all this time. I just finished a shift at work will give it a whirl when i get up!

ghost commented 6 years ago

if you want the right pitch and music speed on mame2003 dank said you just need to set the audio scew and restart retroarch

ghost commented 6 years ago

if you count the music timing in robocop with mame2003 and mame2003 plus youll notice it straight away

KMFDManic commented 6 years ago

@grant2258 You can grab the samples from my Github release, Xtras/Arcade

I posted test video a few posts above.

So, to confirm, which commit should I add, so the Midway Bally will work? Just dont want to muck things up on my end:)

ghost commented 6 years ago

both work the mame2003 =+ one is the one i prefer at the moment the other one basically drops the sample rate to 22050 i dont think your going to want that if a game is less than 48 fps

KMFDManic commented 6 years ago

@grant2258 Very interesting, timing differentials. I did some manipulation to find good mixture of timing to help games like Elevator Action Returns run better on the SNESC. I can see why the timing is such a sensitive subject in the Midway respect. If you recommend the + timing fix, I can try that. Worst case scenario, I can put together a Midway Variant for us Mini Users, in the interum, til things are worked out. Shaders and other cpu intensive settings can potentially do wonders for offsetting fast games, as well.

10 minute mark to see the Elevator Action Returns adjustment

Game normally runs awful on both Retropie and NESC/SNESC. The magic of exploiting RetroArch Settings:)

https://youtu.be/vVMznvqbezk

Looking forward to testing the Midway Timing!

ghost commented 6 years ago

That is interesting. It seems like a lot of work! I'll need to test ea2 I know it's a cpu intensive game