search

libretro / mame2010-libretro

Late 2010 version of MAME (0.139) for libretro. Compatible with MAME 0.139 sets.
33 stars 50 forks source link

Core error at launch - undefined symbol: driver_powerins #128

Open fastpop72 opened 5 years ago

fastpop72 commented 5 years ago

I use the mame2010 core on my bartop, i compiled the source yesterday and today, compile works ok but core doesn't start giving "driver_powerins" error.

I use a PC with debian stretch (x64) and retropie.

I noticed a commit 4 days ago, something has changed on the x64 compiling script?

Thanks.

c0d3h4x0r commented 5 years ago

I'm running into the same thing on my Raspberry Pi 3B+ w/ RetroPie after recompiling this core from source.

c0d3h4x0r commented 5 years ago

It had to be something in this commit: https://github.com/libretro/mame2010-libretro/commit/70c98cffaa793b8b3e75639dbfc31f1cd496bab0

The prebuilt binary of this core for RetroPie -- which doesn't exhibit this issue -- is stamped with commit c87309d, which was the one just before that one.

c0d3h4x0r commented 5 years ago

I also recompiled this core from commit c87309d and it no longer exhibits the issue -- so this was definitely introduced by 70c98cf.

shantigilbert commented 5 years ago

I have the same problem I compiled all the recent versions and the issue is introduced on this commit f44d379c9a22a4cf81a9e4dbfbe43c341cdac6b8

shantigilbert commented 5 years ago

there are a few typos the Makefile.common this patch fixes them 

--- a/Makefile.common
+++ b/Makefile.common
@@ -542,7 +542,7 @@
    $(DRIVERS)/ohmygod.o $(VIDEO)/ohmygod.o \
    $(DRIVERS)/powerins.o $(VIDEO)/powerins.o

-$(MAMEOBJ)/atlus.a: $(ATLUS_OBJ)
+$(MAMEOBJ)/atlus.a: $(ATLUS_OBJS)

 BARCREST_OBJS := \
    $(VIDEO)/awpvid.o \
@@ -1281,7 +1281,7 @@
    $(DRIVERS)/mermaid.o $(VIDEO)/mermaid.o \
    $(DRIVERS)/mjkjidai.o $(VIDEO)/mjkjidai.o

-$(MAMEOBJ)/sanritsu.a: $(SANRITSU)
+$(MAMEOBJ)/sanritsu.a: $(SANRITSU_OBJS)

 SEGA_OBJS := \
    $(DRIVERS)/aladbl.o \
c0d3h4x0r commented 5 years ago

Awesome, thanks! Have you already prepared a pull request? If not, I'll locally recreate your changes, verify them, and create one.

c0d3h4x0r commented 5 years ago

I've commited the change to my fork here: https://github.com/c0d3h4x0r/mame2010-libretro/commit/f9914e380814bf63e284d220731bdf9493b94c97

I've kicked off a local build to verify that it resolves the issue before creating the pull request.

c0d3h4x0r commented 5 years ago

Verified, this cures it. Creating pull request.