search

libretro / mame2010-libretro

Late 2010 version of MAME (0.139) for libretro. Compatible with MAME 0.139 sets.
33 stars 50 forks source link

Fix for Issues #129 and #130 #132

Closed c0d3h4x0r closed 5 years ago

c0d3h4x0r commented 5 years ago

Fix for https://github.com/libretro/mame2010-libretro/issues/130

c0d3h4x0r commented 5 years ago

This also fixes the similar "illegal instruction" crash while trying to launch "Golden Axe: The Duel".

paradadf commented 5 years ago

There are other platforms supported by retropie, not only rpi. Imo you should try to find a more generic way for the platform identification.

c0d3h4x0r commented 5 years ago

I looked for a more generic way and couldn’t find one. This change is better and no worse than what’s in the code already, so I’d recommend taking it.

dankcushions commented 5 years ago

shouldn't platform be fed in by the make command? eg in mame2003 https://github.com/libretro/mame2003-libretro/blob/master/Makefile#L155

retropie will set platform when building via it's internal scripts. i suggest just copying the fallbacks from https://github.com/libretro/mame2003-libretro/blob/master/Makefile#L32 and assume the builder will feed in anything special.

c0d3h4x0r commented 5 years ago

Maybe there’s a bug in RetroPie-Setup, because the mame2010-libretro Makefile is definitely not being passed a value for platform. I’ll look into it.

c0d3h4x0r commented 5 years ago

Yeah, looks like an oversight in RetroPie-Setup/scriptmodules/libretrocores/lr-mame2010.sh. I'm preparing a separate fix for that, and I'll update this pull request accordingly.