search

libretro / mame2016-libretro

Late 2016 version of MAME (0.174) for libretro. Compatible with MAME 0.174 sets.
Other
32 stars 40 forks source link

Updated bgfx to github commit 7b8d531 #25

Open Menion2k opened 5 years ago

Menion2k commented 5 years ago

Updated bx to github commit 13e2211 Added bimg github commit 084e14e

Files from bimg required by bgfx are compiled in the same libbgfx.a library for convinience

Signed-off-by: Menion menion@gmail.com

markwkidd commented 5 years ago

I am not finding a 7b8d531 commit in the MAMEdev repository: https://github.com/mamedev/mame/search?q=7b8d531&type=Commits

Is that the right hash, or did I misunderstand what you were writing about that?

Edit: I want to clarify that I am very excited for this improvement to MAME 2016!

markwkidd commented 5 years ago

For the record, I can't clone this repo's master branch and get to compile in the standard libretro msys2 environment in Windows 10 x64. Seems to be a Makefile issue:

$ make -j3
GCC 8.2.1 detected
fatal: No names found, cannot describe anything.
makefile:942: *** MINGW32 is not set.  Stop.

edit: I also tried make Makefile.libretro -j3 with a similar result. I haven't done any more investigation though

r-type commented 5 years ago

Hum since bgfx is not used in libretro port , i bet we can just remove it!

r-type commented 5 years ago

this should do the trick https://pastebin.com/rEXuTUaC

@Menion2k if you can try to build using this patch to see if it works for you.

r-type commented 5 years ago

@markwkidd did you look at this https://github.com/libretro/mame2016-libretro/issues/9

markwkidd commented 5 years ago

I have to apologize I did not, I've just been following this issue in the forum where it started as an enhancement for RPi/ARM compilation and didn't browse around much here.

I'll read a bit more

r-type commented 5 years ago

@markwkidd for your windows build maybe you can try an make Makefile.libretro -j3 PTR64=1

Menion2k commented 5 years ago

I am not finding a 7b8d531 commit in the MAMEdev repository: https://github.com/mamedev/mame/search?q=7b8d531&type=Commits

Is that the right hash, or did I misunderstand what you were writing about that?

I am not updating mame, I have just updated bgfx and bx to the mentioned commits from their original Github branch in order to solve compilation issues with recent GCC

Hum since bgfx is not used in libretro port , i bet we can just remove it!

Honestly I don't follow this. The original mam2016 libretro porting used bgfx why are you saying it is not needed? Have you beeb able to compile and run mame2016 without it?

r-type commented 5 years ago

Yes if course it run. Btw i have done this port and i know what i mean when i said ,libretro mame dont use bgfx 😁

markwkidd commented 5 years ago

I applied the patch but there still seems to be some fundamental issue with Makefile.libretro for Windows x64:

$ patch -p1 < patch.diff
patching file Makefile.libretro
patching file scripts/genie.lua
patching file scripts/src/3rdparty.lua
patching file scripts/src/main.lua

$ make Makefile.libretro -j3 PTR64=1
GCC 8.2.1 detected
fatal: No names found, cannot describe anything.
make: Nothing to be done for 'Makefile.libretro'.
markwkidd commented 5 years ago

I still have not done any investigating on this myself to be clear. I just plugged those commands into a fresh clone of the master branch.

r-type commented 5 years ago

I have no windows ATM to test an msys2 build, but did you test $ make Makefile.libretro -j3 PTR64=1 or make -f Makefile.libretro -j3 PTR64=1 as you should use the "-f" to point the makefile.

markwkidd commented 5 years ago

@r-type thank you, that built!

There is still a Makefile syntax error somewhere but it doesn't seem to be a big problem because with your patch applied I was able to build a functioning MAME 2016 core in the Windows 10 x64 msys2 environment.

r-type commented 5 years ago

nice to here! BTW this patch also works with the last mame core, as i repeat we don't use for now bgfx in mame libretro core. maybe we can commit it and close this PR then.

Menion2k commented 5 years ago

I have very little time to apply the patch and resubmit the PR, I don't have anything against that someone pick my branch, apply the bgfx patch and submit the PR Bye

inactive123 commented 5 years ago

Alright, so what is the consensus here? Should bgfx be removed? AFAIK, it just adds additional lag and it was not ideal right now since no emulators inside MAME use it for hardware acceleration anyway. So get rid of it or not?

klepp0906 commented 5 years ago

same issue. cant compile. same error about mingw32 not being set.

not that this needed another voice, but since i found it looking for a solution >.>