Closed KMFDManic closed 2 years ago
I'm not a maintainer for this core so not sure it's useful to ping me from other PRs about this :). Looks ok to me EXCEPT you can't overclock beyond 150% ? What about games that would appreciate an overclock instead of a downclock ? I know there is a limitation of 64 values for a core option (except if it finally got removed ?) but maybe the granularity between 11 and 54 is overkill here ?
Edit : oh wait, isn't there 65 values here ? are you sure it's within limit ?
Edit2 : nevermind, i checked current value of RETRO_NUM_CORE_OPTION_VALUES_MAX
and it seems to be 128 now, probably a recent change since i remember hitting the previous 64 limit with my "cheats to core option" converter
Same remark as @barbudreadmon - I'm not a maintainer here, but it looks ok to me in general.
Thanks!
I mainly just wanted to run it by you guys, since you both were agreeable to the changes last time. In any case, thanks!
@twinaphex this would be for you to merge. I have tested the lower numbers on several dozen games, with considerable success. This would be a helpful addition for those who need just a little more push out of the Core.
I also was able to get N64/Dreamcast, fixed up for the Mini Classics. Thanks, as always, for your constant insight, as well as the many other helpful people in the Libretro Scene, when things come up!
On lower spec hardwares, such as Pi, Mini Classics, values 11-29 are detrimental in helping better run games like Deathsmiles, Outfoxies, Sega System 32 Games, etc., which are otherwise nearly impossible to run well! I have had this implemented for awhile in MAME 2003 Xtreme, which really helps on Killer Instinct and Cruis'n USA!
Personal thanks pjft on 2016; grant2258 on 2003 Plus/Xtreme!