libretro / mame2016-libretro

Late 2016 version of MAME (0.174) for libretro. Compatible with MAME 0.174 sets.
Other
32 stars 40 forks source link

compilation failures with gcc 6.3.1 #8

Open audetto opened 7 years ago

audetto commented 7 years ago

These have been fixed upstream

https://github.com/mamedev/mame/commit/7099d6eaa22b8958f133b4f9eec6a8705a30b2d8

../../../../../src/devices/cpu/asap/asapdasm.cpp: In function ‘offs_t cpu_disassemble_asap(cpu_device, char, offs_t, const UINT8, const UINT8, int)’: ../../../../../src/devices/cpu/asap/asapdasm.cpp:92:6: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] else ^~~~ ../../../../../src/devices/cpu/asap/asapdasm.cpp:93:94: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’ sprintf(buffer, "add%s %s,%s,%s", setcond[cond], reg[rsrc1], src2(op,0), reg[rdst]); break; ^~~~~ ../../../../../src/devices/cpu/asap/asapdasm.cpp:105:6: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] else ^~~~ ../../../../../src/devices/cpu/asap/asapdasm.cpp:106:94: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’ sprintf(buffer, "or%s %s,%s,%s", setcond[cond], reg[rsrc1], src2(op,0), reg[rdst]); break; ^~~~~

or

../../../../../src/frontend/mame/ui/miscmenu.cpp: In destructor ‘virtual ui::menu_plugins_configure::~menu_plugins_configure()’: ../../../../../src/frontend/mame/ui/miscmenu.cpp:903:60: error: throw will always call terminate() [-Werror=terminate] throw emu_fatalerror("Unable to create file plugin.ini\n"); ^ ../../../../../src/frontend/mame/ui/miscmenu.cpp:903:60: note: in C++11 destructors default to noexcept

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/43413388-compilation-failures-with-gcc-6-3-1?utm_campaign=plugin&utm_content=tracker%2F52957340&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F52957340&utm_medium=issues&utm_source=github).
c0d3h4x0r commented 4 years ago

It looks like the real problem is lack of clear instructions about how to build this libretro core. Apparently you need to use the command make -f Makefile.libretro rather than just make, so that it picks up and uses the libretro-specific Makefile -- which, among other things, disables warnings-as-errors.