search

libretro / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
68 stars 72 forks source link

Games (for example: MOTHER 3 Patched w/ Fan Translation 1.2) aren't creating the proper save files. #123

Open TopHatHipster opened 5 years ago

TopHatHipster commented 5 years ago

Some games (I only found MOTHER 3 patched with the 1.2 version of the English fan translation) create invalid save files which causes the game not to want to save or is unable to open up the save file.

In MOTHER 3's case: it uses 128kB save files instead of the usable 64kB save file. It is not the game's fault as another GBA libretro core (VBA-Next) can create a proper save file for the game just fine.

Might be the result of an error in this save data code.

bslenul commented 5 years ago

So I tried yesterday with an "old" version of the core (0.7-WIP 9dd7301) and it worked fine, I could save and load without any problem (the .srm file was 64KB):

image

Then I updated the core to the latest version (using the RA Core Updater) and on the main menu of the game the "LOAD" option was gone and the .srm file is now 128KB.

If I switch back to the "old" core the "LOAD" option reappears and the .srm is back to 64KB.

Both my 64KB and 128KB .srm files if that can help somehow: Mother_3_saves.zip

jdgleaver commented 5 years ago

I can confirm that this is an upstream issue - I've reported it at the main repo: issue #1221

TopHatHipster commented 5 years ago

I can confirm that this is an upstream issue - I've reported it at the main repo: issue #1221

Thank you very much for the much more detailed information. I hope this'll be solved very soon.

Awakened0 commented 5 years ago

Should be fixed now: https://github.com/libretro/mgba/commit/9262475cb47c1bbfd4422591394b789ce18f6b6b