search

libretro / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
68 stars 73 forks source link

PS3 - Since build a2f10c3 _initSensors makes core unusable #211

Closed crystalct closed 3 years ago

crystalct commented 3 years ago

With _initSensors(); all input systems on PS3 are breaked, making the core unusable.

endrift commented 3 years ago

Well that's...not...a real fix at all. It'd be okay for a temporary workaround, but it also merged in an incorrect fix for a warning. @twinaphex, you've violated the PR rubber stamp agreement we had. That didn't take very long...

endrift commented 3 years ago

Also that sensors code is what's causing the Android crash (#199) in the first place so maybe if you fixed it it'd be the right fix for this too.

crystalct commented 3 years ago

I'm tiring to solve all issues from PS3 point of view (i have hardware and sdk for that). Now v0.8.4 intruduced somewhere a segmantation fault more complex than _initSensors(), cause many source lines changed with commit 2a221b3. For now PR #212 just remove _initSensors() only for PS3 build, and yes is a workaraound... i just thought what sensors the PS3 has... none, thinking about movement sensors.... i will take a look after segmentation fault.

endrift commented 3 years ago

Sorry, I was talking about this: https://github.com/libretro/mgba/commit/54a1f8ebc0989676b7b1d6a43bf3047c2ffe746e#diff-d2b005acdc7ac7cf1e97088828dedc7536894a7f180b48c270b334d7078adc8cR65-R69 which is unrelated to the point of that PR and I would have complained about had it not gotten rubber stamped before I noticed. As I said, the ifdefs are a temporary fix and I wouldn't have held up a PR over. I had thought I was commenting in the PR when I left the first comment (the GitHub iOS app was a little less than clear when I'd clicked over from my email), so the comments I left were actually supposed to be in there, but...oops...

crystalct commented 3 years ago

You are talking about only chnages about initsensor, right? Because fisrt two are only corrections necessary for PS3 enviromnet. Max-path = 4096 is wrong on FS filesystem of PS3 and gettimeofday doesn't exist on Sony SDK for PS3. The correct ways should be a PR for first two Ps3 environment specific and another for walkaround for issues #211?

endrift commented 3 years ago

I'm talking about the changes to common.h. Particularly, I'm talking about putting the prototype in that file. There was a PR merged recently that implemented that function in formatting.c; thus, the prototype should accordingly be put in formatting.h. You didn't necessarily know that, but it got merged before I had a chance to ask you to fix it. That's the primary issue here.

crystalct commented 3 years ago

Ok... i can remove it.... and i can put in a better position ..or remove it at all and keep waring "implicit declaration of function 'gettimeofday'".... what do you suggest me?

endrift commented 3 years ago

I'll get back to you on that tomorrow. It's too late at night for me to really be thinking about this. I guess I should get around to trying to do the actual sensors fix too since no one else has yet. It hasn't really been very high up on my list of priorities lately.

crystalct commented 3 years ago

Ok...In italy is lunch time ^_^ good night