Expose and update emulator version

Ryunam commented 3 years ago

Just a quick update to libretro.c to expose the emulator version (currently 0.9.2) before the commit hash, as was the case for the previous versions of the same core.

inactive123 commented 3 years ago

Hi there @endrift , I'll leave it up to you to approve this or not.

endrift commented 2 years ago

That version number isn't even accurate...this is closer to 0.10 than 0.9.2. It's impossible to keep an accurate version number in the libretro core that actually maps to the same thing as the standalone.

endrift commented 2 years ago

Not to mention the fact that we'll have to remember to update it with any regularity. Which historically hasn't been done.

endrift commented 2 years ago

...Doesn't this also elide a separator between the version number and the git commit, so it'd be 0.9.2fda6556...? Not exactly readable.

Ryunam commented 2 years ago

Hi @endrift, let me try to address a few of your concerns here:

I understand that the versioning in the libretro core may be difficult to track accurately. The logic behind this proposal is that, without there being this hard-coded string, there was no way to gauge which version of the software was being used, apart from checking the commit hash. I chose 0.9.2 here because, to the best of my knowledge, that one is the latest stable release. It is an approximation though, no way around that.
Being the one who suggested this change, I intend to keep an eye on this aspect on the libretro side, so that the version number is updated regularly enough.
As far as the separator is concerned, there is actually a space that divides the version number and the commit hash, as seen in the footer menu here:

Screenshot 2021-10-17 160906

That is because the code in the libretro makefile does take into account that space: https://github.com/libretro/mgba/blob/fda6556195b0f6a3cc70c3b64297ad31a064f275/Makefile.libretro#L82

This is the formatting that is also used with all the other cores that show the internal version number and the commit hash. I believe it should be readable enough, but if you'd rather have some more distinct separator I can add it as well.

libretro / mgba

Expose and update emulator version #240