libretro / mupen64plus-libretro-nx

Improved mupen64plus libretro core reimplementation
GNU General Public License v2.0
231 stars 114 forks source link

iOS version black textures issues #219

Open WeedyWeedSmoker opened 4 years ago

WeedyWeedSmoker commented 4 years ago

Hi @m4xw, I thought for a long time that the iOS 64-bit version always had some "black texture issues", but it seems that's only happening with the main iOS branch… https://forums.libretro.com/t/retroarch-1-8-5-certain-textures-are-black-mupen64plus-next/27308/9

This fork from @jet082 actually works mostly fine : https://github.com/jet082/mupen64plus-libretro-nx/commit/a7adaf2e253a445081d5b450ef063f62e4dd5b8d

I really don't know how to help but the official RetroArch iOS and tvOS .ipa releases use this commit and not the latest version from your main iOS branch…

Thanks!

estefan3112 commented 2 years ago

I can test this. It’s been a while but can you refresh my memory. Is there an ipa ready or does the rebase branch need to be compiled?

You need to compile the branch and put the library into the uncompressed RetroArch.ipa.

HappehLemons commented 2 years ago

Hi m4xw, for me the issue still persists. I compiled both branches with identical results in Yoshi's Story, and in Gauntlet Legends, the HUD display is still garbled and unsusable. Sorry for no better news. In Retroarch the core is called Mupen64Plus-Next (2.3-GLES3 git)

Looks like you ahead on me for this one. I'll take your word that this doesn't work versus breaking out my macbook to clumsily compile this. Thanks for trying @m4xw! Hope to one day see this fixed.

HappehLemons commented 2 years ago

Not sure if this is relevant, but https://github.com/Provenance-Emu N64 Mupen core seems to have had the same issue previously, but with one of their recent updates it has been fixed. Unsure if there's information within their github that could be helpful here.

m4xw commented 2 years ago

Hi, can someone try https://github.com/libretro/mupen64plus-libretro-nx/commits/ios

m4xw commented 2 years ago

Getting closer to the root cause..

m4xw commented 2 years ago

@estefan3112 Where are u mate :P

m4xw commented 2 years ago

A: https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/jobs/2596873/artifacts/browse B: https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/jobs/2596874/artifacts/browse One of them should fix it 🤞

m4xw commented 2 years ago

(turn LOD emu off)

cplepage commented 2 years ago

A 027ABA72-8F0F-4799-BD2F-C9598C5BB705 FB755607-3DF2-4434-AA2C-272E12740CAE

B 5CA81213-85AE-49C0-8736-1FC301AB90B7 0EC44A83-2AE4-4EC2-8C93-0FF2E09348BA

Wow great job @m4xw ! There’s still a few textures missing, but the game is more playable than ever! Tried on RetroArch 1.11.1

m4xw commented 2 years ago

I hate my life

m4xw commented 2 years ago

Also just to be clear, the way i ""fixed"" it isnt proper, but this confirms the issue at hand so I will get this fixed properly.

Both IOS and emscripten have the same restriction not allowing textures that arent power of two for some reason, even tho it should get a GLES3 context. So expect some extra bugs that arent present otherwise till then, but this should cover most texture cases

estefan3112 commented 2 years ago

@estefan3112 Where are u mate :P

Hi, having major codesingning issues, still trying to resolve them...

estefan3112 commented 2 years ago

@estefan3112 Where are u mate :P

Hi, having major codesingning issues, still trying to resolve them...

Finally, some testing (LOD disabled):

Cheers!

Edit: Identical results with LOD enabled in version B.

m4xw commented 2 years ago

@estefan3112 Where are u mate :P

Hi, having major codesingning issues, still trying to resolve them...

Finally, some testing (LOD disabled):

* own compile and pre-compiled version A: heavily broken, more broken than before

* pre-compiled version B: best results so far, Gauntlet Legends clearly better, Yoshi's Story looks very nice so far, HiresTextures e.g. in Super Mario 64 still severely broken
  Thus I opt for version B ;-).

Cheers!

Edit: Identical results with LOD enabled in version B.

Are u still on discord btw?

Also can u add a pic with high res? Fwiw i will need to work around this in software most likely

estefan3112 commented 2 years ago

@estefan3112 Where are u mate :P

Hi, having major codesingning issues, still trying to resolve them...

Finally, some testing (LOD disabled):

* own compile and pre-compiled version A: heavily broken, more broken than before

* pre-compiled version B: best results so far, Gauntlet Legends clearly better, Yoshi's Story looks very nice so far, HiresTextures e.g. in Super Mario 64 still severely broken
  Thus I opt for version B ;-).

Cheers! Edit: Identical results with LOD enabled in version B.

Are u still on discord btw?

Also can u add a pic with high res? Fwiw i will need to work around this in software most likely

Yes m4xw, I am still on Discord, which channel?

Here are some shots - don't be surprised: These are shots from MacOS Catalyst running Retroarch iOS absolutely seamlessly on my Apple M1 Silicon besides some minor hickups (e.g. no save states option) - but the gfx output is identical to that of the iPad, so its fun to test!

First some screenshots without hires:

Bildschirmfoto 2022-10-10 um 18 52 00

Yoshi's World - quite perfect!

Bildschirmfoto 2022-10-10 um 19 04 17

Super Mario 64 without hires

Bildschirmfoto 2022-10-10 um 19 12 54

Gauntlet Legends - minor problems in the boxes, but much better than before

Bildschirmfoto 2022-10-10 um 19 14 22

Zelda OOT - just fine

Next some hires pics.

estefan3112 commented 2 years ago

Super Mario 64 Hires Mollymutt:

Bildschirmfoto 2022-10-10 um 19 27 04 Bildschirmfoto 2022-10-10 um 19 27 17 Bildschirmfoto 2022-10-10 um 19 27 50 Bildschirmfoto 2022-10-10 um 19 28 14
estefan3112 commented 2 years ago

And finally Zelda OOT Hires Textures:

Bildschirmfoto 2022-10-10 um 19 30 57 Bildschirmfoto 2022-10-10 um 19 31 04 Bildschirmfoto 2022-10-10 um 19 31 24