search

libretro / parallel-n64

Optimized/rewritten Nintendo 64 emulator made specifically for Libretro. Originally based on Mupen64 Plus.
310 stars 128 forks source link

Fix Seg Fault on Game Unload #637

Closed mrfixit2001 closed 4 years ago

mrfixit2001 commented 4 years ago

When commit https://github.com/libretro/parallel-n64/commit/11c1ae337bdbb8929761bb61b812f61ae6b47303 split r4300_execute into r4300_execute and r4300_init, it continued to check the "stop" variable, but this is undefined. Removing these checks resolves the seg fault and does not affect functionality.

Should address: https://github.com/libretro/parallel-n64/issues/636 https://github.com/libretro/parallel-n64/issues/592 https://github.com/libretro/parallel-n64/issues/580 https://github.com/libretro/parallel-n64/issues/571

And possibly others.

MastaG commented 4 years ago

Verified on Odroid XU4. Parallel-n64 now being the best emulator :)