search

libretro / parallel-n64

Optimized/rewritten Nintendo 64 emulator made specifically for Libretro. Originally based on Mupen64 Plus.
309 stars 128 forks source link

hide GL core options with HAVE_OPENGL=0 and apply it to OSX and iOS #740

Closed hunterk closed 2 years ago

hunterk commented 2 years ago

OSX and iOS both break with any OpenGL options but are fast enough to deal with LLE software rendering. Unfortunately, they insta-crash on load unless users manually set the plugins to Angrylion and cxd4/ParaLLEl-RSP via text editor, which is a pretty big ask (they have to know the exact syntax, etc.).

This PR forces those plugins and removes OpenGL entirely from those builds, while also doing a better job of hiding GL-dependent core options.

metchebe commented 2 years ago

Hello.

I'm using Parallel-N64 on Linux aarch64 with FORCE_GLES=1 and this update removes the normal options available (choose plugins, choose filter type, maybe others I didn't notice). The rendering still works with 'auto' plugins but I cannot change the filtering type.

I understand this PR should only affect OSX / iOS, I suppose these changes are not intended (for my setup at least).

I made an up to date build at be3d7cd, but reverting this PR, and it works as expected.

hizzlekizzle commented 2 years ago

I can make the ifdefs check for FORCE_GLES, as well. That should resolve it.

metchebe commented 2 years ago

Hi again. I wanted to comment that maybe this also affects builds that use GLES without FORCE_GLES=1, such as 'platform=rpi3' for example.

hizzlekizzle commented 2 years ago

Ok, I have this fixed (I think) in my fork, but metchebe's going to try testing it out tomorrow. If that gets it, I'll send another PR.

metchebe commented 2 years ago

I tried the hunterk fork at 587c537 and unfortunately the issue is not fixed.

hizzlekizzle commented 2 years ago

alright, can you try it again? I changed the ifdef.

metchebe commented 2 years ago

Yes 971380b is OK, thank you.