search

libretro / parallel-n64

Optimized/rewritten Nintendo 64 emulator made specifically for Libretro. Originally based on Mupen64 Plus.
309 stars 128 forks source link

Updated to current libretro-common #779

Closed albertofustinoni closed 2 days ago

LibretroAdmin commented 4 days ago

Does it still work after this change? Has that been tested?

albertofustinoni commented 3 days ago

I have tested this and it works in my environment.

LibretroAdmin commented 2 days ago

You forgot to add files to this PR -

https://git.libretro.com/libretro/parallel-n64/-/jobs/5395245

I'll do it myself I guess

LibretroAdmin commented 2 days ago

I'm sorry but this just isn't going to properly compile.

Even after I put rglgen_private_headers.h back in, I get this -

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/13.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: ./libretro-common/audio/resampler/drivers/null_resampler.o:null_resampler:(.data+0x0): multiple definition of `null_resampler'; ./libretro-common/audio/resampler/audio_resampler.o:audio_resample:(.data+0x0): first defined here collect2.exe: error: ld returned 1 exit status make: *** [Makefile:1043: parallel_n64_libretro.dll] Error 1

I'm reverting this. If you send another PR that resolves all these issues (and that this time is properly tested), I'll merge it.