fix sram issue in demons of asteborg

libretro / picodrive

Fast MegaDrive/MegaCD/32X emulator

Other

38 stars 60 forks source link

fix sram issue in demons of asteborg #170

Closed madmonkey1907 closed 2 years ago

inactive123 commented 2 years ago

@irixxxx Hope I didn't jump the gun here. Let me know if there are issues with this here. I couldn't see any myself at least but then again I'm not an expert.

irixxxx commented 2 years ago

I don't see issues here. The only question I have is what mirroring of that address might exist. For correctness it might be needed to mask the address before the comparison. OTOH it might not even change the behaviour if the ROM software is doing all accesses only by this one address, so there is probably nothing to gain here.

irixxxx commented 2 years ago

checked back on this one. No objections. (although I'm going to rewrite this a tiny bit for smaller code)