search

libretro / picodrive

Fast MegaDrive/MegaCD/32X emulator
Other
40 stars 63 forks source link

add HAVE_ARMv6 = 0 + minor fixes #199

Closed Apaczer closed 2 years ago

Apaczer commented 2 years ago

PicoDrive's Arm cores building need HAVE_ARMv6 = 0 for Miyoo.

jSTE0 commented 2 years ago

I noticed this breaks CI with:

make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
g++ -Wall -ggdb -DCONFIG_FILE="\"../cyclone_config.h\"" -DHAVE_ARMv6=0   -c -o Main.o Main.cpp
/bin/sh: 1: g++: not found
make[1]: *** [<builtin>: Main.o] Error 127
make[1]: Leaving directory '/builds/libretro/picodrive/cpu/cyclone'
make: *** [platform/common/common.mak:203: cpu/cyclone/Cyclone.s] Error 2
make: *** Waiting for unfinished jobs....

The vita and ctr (3ds) builds are fine (being also arm32 builds) and they use the host g++ as well. I'm guessing this needs to be fixed as part of CI infrastructure, how do we do that?

jSTE0 commented 2 years ago

@jdgleaver I think https://git.libretro.com/libretro-infrastructure/libretro-build-dingux/-/blob/master/Dockerfile needs g++ added to the apt-get install.

irixxxx commented 2 years ago

Alternatively, switch from the Cyclone 68000 emulator to Fame. That doesn't need C++. AFAICT it's also not a big difference in performance.

jdgleaver commented 2 years ago

@jSTE0 I've updated the build container and the pipeline now succeeds. g++ was originally omitted because we only had MIPS targets when the dingux build container was first set up. You did well to spot the issue here :)

jSTE0 commented 2 years ago

@jdgleaver Thanks for fixing it quickly. @irixxxx Looks like it's fixed, at least this keeps it consistent with the other Arm builds.