search

libretro / picodrive

Fast MegaDrive/MegaCD/32X emulator
Other
38 stars 60 forks source link

Blackthorne broken sound/music #217

Closed KamiLordus closed 1 year ago

KamiLordus commented 1 year ago

After the latest update, Blackthorne has broken sound/music. Already in the menu, the music breaks down, there are strange sounds, etc. In the game itself, I noticed that there is no gunshot sound at all.

Retroarch 1.15 Win11

DrUm78 commented 1 year ago

Yep, the guilty is https://github.com/irixxxx/picodrive/commit/805fbe6faa2cc98821356828af5055f0cd6584bd, it also broke the display (random while in game): image image

irixxxx commented 1 year ago

I already noticed that and have a fix for the intro music, but don't know if this works for your other problems as well. If you are able to compile the core yourself I could post the small fix here for you to try out.

KamiLordus commented 1 year ago

@irixxxx not only in the intro there is a problem. The music works in the game, but the sounds don't. You can't hear gunshots, picking up items, jumping, footsteps, etc. @DrUm78 you're right, I didn't notice that. The image display is also broken.

irixxxx commented 1 year ago

Whatever, I found a fix for the intro. @DrUm78 has already tested it and it works through for him for the other problems too. So, in pico/32x/memory.c, change the THRESHOLD in line 62 from 9 to 11, and all is hopefully well again.

KamiLordus commented 1 year ago

@irixxxx could you add this fix for retroarch ? I don't see that option anywhere.

irixxxx commented 1 year ago

Not before my local evening, which is still several hours away.

KamiLordus commented 1 year ago

No problem :) I'm not that impatient.

irixxxx commented 1 year ago

compile a core from the repo or get the latest from https://git.libretro.com/libretro/picodrive/-/pipelines for testing.

irixxxx commented 1 year ago

According to reports from @DrUm78 and others I think this is fixed with f81718c

KamiLordus commented 1 year ago

Yes, the problem has been fixed. Thank you.