search

libretro / prosystem-libretro

Port of ProSystem to the libretro API.
GNU General Public License v2.0
13 stars 39 forks source link

Fixed RA info base_height #66

Closed rtomasa closed 2 years ago

inactive123 commented 2 years ago

https://github.com/libretro/prosystem-libretro/blob/b6f5ae5ee1812270b522e8950087657247f84ebf/core/libretro.c#L622

Can videoHeight be anything other than 223 and/or 272? If so, how does it account for this with your patch?

rtomasa commented 2 years ago

It shouldn't. This system only have one resolution depending on if it is NTSC or PAL. Currently it is even worse because it is always reporting a hardcoded 320x240 which is totally wrong, so better to output the correct one even if it is also hardcoded. Of course it would be better to carefully analyze how the core is made, why is using a fixed 240p and fix it in a more proper way