search

libretro / px68k-libretro

Portable SHARP X68000 Emulator for Libretro
http://hissorii.blog45.fc2.com
GNU General Public License v2.0
45 stars 40 forks source link

Restore MIDI output core options #167

Closed bslenul closed 1 month ago

bslenul commented 8 months ago

Closes #166

Kelvfimer commented 3 months ago

@bslenul if "px68k_midi_output", is set to off at least Castlevania is not starting.

I would like to check what is the right setting. I was using these settings px68k_midi = "enabled" and px68k_midi_type = "LA" instead of the output ones you used.

Kelvfimer commented 3 months ago

Strange those values px68k_midi = "enabled" and px68k_midi_type = "LA" doesn't exist in the code but I took them from here and they are working https://retropie.org.uk/forum/topic/33298/playing-x68000-games-with-midi-music

gingerbeardman commented 3 months ago

INI file settings are converted into a Config structure that is used in the code. It's here in the code:

https://github.com/libretro/px68k-libretro/blob/4c7542e34df71e3ebab77b5867901747d58dbb38/libretro.c#L320-L349

Kelvfimer commented 3 months ago

@gingerbeardman the values of the page for sure are not the right ones.

@gingerbeardman can you merge this PR? thx or it is @LibretroAdmin the one who should do it? thx