search

libretro / px68k-libretro

Portable SHARP X68000 Emulator for Libretro
http://hissorii.blog45.fc2.com
GNU General Public License v2.0
45 stars 41 forks source link

MIDI: Fix instruments not getting initialized (windows) #173

Closed negativeExponent closed 2 months ago

negativeExponent commented 2 months ago

In windows, instruments remain as pianos/uninitialized regardless Midi type option set and other configurations. It appears that in windows, the midi command program change does not like the extra byte writes. It woks fine under linux.

This minimum PR should fix this issue (as far as instruments getting initialized that is).

Future proof would be to use actual midi msg lengths and others (delta time? write exclusive?)

Fix https://github.com/libretro/px68k-libretro/issues/164

negativeExponent commented 2 months ago

things still are not sounding right between nuke sc55 and munt...., so im leaving this to someone who is using windows and interested, as running windows is just too slow on my PC.

core runs midi fine under linux.