search

libretro / px68k-libretro

Portable SHARP X68000 Emulator for Libretro
http://hissorii.blog45.fc2.com
GNU General Public License v2.0
45 stars 41 forks source link

KeyBindings in a table array with comments, new key combinations for unmapped keys, analog controller support etc #186

Closed negativeExponent closed 1 week ago

negativeExponent commented 2 weeks ago

Fix https://github.com/libretro/px68k-libretro/issues/142

@LibretroAdmin @hunterk @hizzlekizzle

hizzlekizzle commented 1 week ago

Wow, ton of great stuff in here. I'll see if we can get it merged ASAP.

I wasn't sure if this was actually an (unimportant) issue or just a missing font on my system or something: image

negativeExponent commented 1 week ago

thanks for the reply. bah that txt do not mean anything relevant. i have a lot to port from my repo of px68k, including comment translations but its dragging to much waiting for things to get merged or evaluated. anyone else i can tag to evaluate at least to make things go faster?

hizzlekizzle commented 1 week ago

Hmm, not sure. I just now saw it and pinged libretroadmin on discord to make sure he sees it. I'm not sure who else, other than him, has merge rights to the repo (I don't, but I can usually get eyes on stuff).

gingerbeardman commented 1 week ago

I wasn't sure if this was actually an (unimportant) issue or just a missing font on my system or something:

The Japanese text in the original file used Shift-JIS text encoding, not modern Unicode, so some editors will mangle it. The correct way to keep it is to use a editor that will convert to Unicode, or edit the files as Shift-JIS. On macOS I use Cot Editor, which can do both, not sure about other platforms like Win/Linux. VSCode cannot do it as far as I know.

I raised the issue of keeping the comments a while ago, but there were unanswered questions that the Libretro team wanted to wait on. And then the comments just started getting mangled in commits.

ps: the selected text refers to use of MAME-compatible register numbers. I think it's pretty relevant, as are most of the comments, that's why they were written!

LibretroAdmin commented 1 week ago

Sorry for the delay @negativeExponent. There will hopefully be less time until merge from now on.