search

libretro / px68k-libretro

Portable SHARP X68000 Emulator for Libretro
http://hissorii.blog45.fc2.com
GNU General Public License v2.0
45 stars 41 forks source link

Don't save FDD and HDD paths to config file #58

Closed alice-mkh closed 4 years ago

alice-mkh commented 6 years ago

Also, what's up with all the #if 0'd dead code? Should I just remove it instead? :)

alice-mkh commented 6 years ago

https://xkcd.com/1172/? :) If existing users were expecting that, they wouldn't open the issue. Additionally, this is clearly a bug: you're loading one game, but a completely different one loads.

gingerbeardman commented 6 years ago

It may help to make a list of possible scenarios:

  1. user selects floppy disk game
  2. user selects hard disk game
  3. user starts core manually with no game

The best solution would satisfy all three.

inactive123 commented 5 years ago

Hi, where do we stand with this PR?

alice-mkh commented 5 years ago

Well, I still not sure about the scenario #3. Are there any cores that do that? The current behavior is just completely unintuitive, as you load one game and another one loads for no reason

gingerbeardman commented 5 years ago

you load one game and another one loads for no reason

@Exalm is this actually true? If so it's not covered by any of the above scenarios.

Or are you referring to 3, when a user starts the core it loads the last game they were playing?

alice-mkh commented 5 years ago

Yes, it is true. Try this:

  1. Load a game from a floppy image
  2. Close it
  3. Load a game from an HDD image. Oops, it still loads the game from that floppy
gingerbeardman commented 5 years ago

Yes, it is true. Try this: ...

@Exalm the thing is, that's exactly what would happen with the real hardware. You would need to eject the floppy for it to not take booting order precedence over the hard drive.

My uncommitted changes add an option for the user to choose whether or not they want this kind of realistic persistence.

At this point, though, I really don't have strong opinion either way on this. (Though I still believe that any changes to long-standing behaviour should come as a toggle option.)

negativeExponent commented 4 years ago

this can now be closed. implemented as core options i latest commit