search

libretro / px68k-libretro

Portable SHARP X68000 Emulator for Libretro
http://hissorii.blog45.fc2.com
GNU General Public License v2.0
45 stars 41 forks source link

Converted text encodings from various Japanese to UTF-8 #99

Closed gingerbeardman closed 4 years ago

gingerbeardman commented 4 years ago

Exception: I believe that the file menu_str_sjis.txt needs to be Shift-JIS for this to build. So I have left the file untouched and instead created an extra file menu_str_utf8.txt to test that out.

I do not currently have a build system set up, so please check this builds before merging.

gingerbeardman commented 4 years ago

@negativeExponent those few were fixed in https://github.com/libretro/px68k-libretro/pull/99/commits/37370b88323b745e4542c61b64343b154d19d18d your referenced file is from a slightly older commit (see "outdated" label)

negativeExponent commented 4 years ago

then these should be ok then. just convert the rest if there are any along the way

gingerbeardman commented 4 years ago

I think we're good, I converted them all via automation and then verified them all by hand and reverted/fixed those few rogues.

negativeExponent commented 4 years ago

i didn't notice this before. only source files/headers should have been converted. the rest left alone like .txt files and the sjs.txt for the menu (since there is already a separate file for this)

inactive123 commented 4 years ago

Hi @gingerbeardman,

got any idea if the resultant text encodings would still be compilable with older compilers like MSVC 2003 and older GCC versions like on Power PC Mac (circa 4.x ish ) ?

gingerbeardman commented 4 years ago

@negativeExponent I left the menu text file unchanged, see PR message. Let me know the names of any problematic files.

@twinaphex then the question is whether those handle files encoded as UTF-8 (without BOM)? I believe they both do.

They've been dealing with EUC-JP, Shift-JIS etc. all this time.

gingerbeardman commented 4 years ago

If we don't think this is needed I'm happy for it to be closed without merge.

Thoughts @negativeExponent ?

negativeExponent commented 4 years ago

If we don't think this is needed I'm happy for it to be closed without merge.

Thoughts @negativeExponent ?

there's no harm leaving the PR there for now. everyone is busy preparing for next RetroArch release. if you are able to release log that this japanese text in utf8 compiles fine in say msvc 2003 then that would probably make reviewing faster. if it does not work, probably just leave encoding (i think most are in EUC-JP and 8859-1?) at stock until all text on a file can be translated.

i dont have any last say in these though.

@gingerbeardman to be honest, these extra precaution just came up recently because someone (YES, i just said someone) has pushed PRs which are now causing problems with older platforms/compilers)

gingerbeardman commented 4 years ago

gonna close this, can redo at some point if it's really needed.

negativeExponent commented 3 years ago

i wanted to reopen and continue this conversion discussion, but repo is already gone. in anycase, looking at quasi88, the source files are in utf8 while maintaining the japanese text. I believe the original sourcefiles/source encodings are the same with px68k. is there a way to test compile for mvsc targets? travis probably? or the new CI whatever is used now?

gingerbeardman commented 3 years ago

Possibly, but that is outside of my area.

Still happy to actually help with, or do, the conversion and translation after compiler queries are answered.