search

libretro / retroarch-assets

Assets needed for RetroArch - e.g. menu drivers, etc. Also contains the official branding.
Creative Commons Attribution 4.0 International
170 stars 161 forks source link

Missing some icons in Retroactive theme. #262

Closed ofry closed 5 years ago

ofry commented 5 years ago 
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_room.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_room_lan.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_room_relay.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_shutdown.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_DPAD-U.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_DPAD-D.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_DPAD-L.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_DPAD-R.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_STCK-U.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_STCK-D.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_STCK-L.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_STCK-R.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_STCK-P.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_SELECT.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_START.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_BTN-U.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_BTN-D.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_BTN-L.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_BTN-R.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_LB.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_RB.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_LT.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_RT.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_check.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_add.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_brightness.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_pause.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_apply_toggle.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_apply_cog.png
baxysquare commented 5 years ago

Thanks @ofry for the tip. Honestly, I don't spend as much time on the repository these days, so I really appreciate when someone lets me know that we need some new additions.

baxysquare commented 5 years ago

I've submitted the PR for the Automatic and Systematic themes. I will try and get to Retroactive and Neoactive themes by the end of the week.

ofry commented 5 years ago

Big thank you.

ofry commented 5 years ago

Still missed some icons:

[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_LB.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_RB.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_LT.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\input_RT.png
[WARN] [XMB] Asset missing: assets\xmb\retroactive\png\menu_add.png
baxysquare commented 5 years ago

Apparently, I missed the fact that the trigger names used underscores instead of dashes like the rest of the input icons, so I went ahead and renamed them. I had also left out menu_add for Retroactive and Neoactive, so they are now added.

I believe that takes care of this issue along with #268, #269 and #270. If you could take a quick look to confirm that resolution. I'd really appreciate it. Thanks @ofry for keeping us "checked and balanced."

ofry commented 5 years ago

Hello again.

Gamepad buttons' icon names should not have DPAD substring.

baxysquare commented 5 years ago

Thanks again @ofry! As you can tell, naming files must not be my strong suit at this stage of my life. Apparently, I was paying more attention to the designs of these new icons than what they're actually supposed to be called. I'll try to do better in the future.

ofry commented 5 years ago

Big thank you!