RGUI/Fire&Blue&Lines & XMB/Essential Menu updates

fpscan commented 5 years ago

retroarch_2019-07-25_22-07-51 retroarch_2019-07-25_22-18-50 retroarch_2019-07-25_22-30-05

inactive123 commented 5 years ago

Hey @jdgleaver , try to review this when you get the chance. Thanks!

fpscan commented 5 years ago

Hey @jdgleaver , try to review this when you get the chance. Thanks!

Yes @jdgleaver , I also sent dm on Discord, my username over there is Gadsby.

jdgleaver commented 5 years ago

@fpscan Hey, that's great! I love those wallpapers. It's so nice to see other people making RGUI custom themes :)

I have just a few comments:

Lines.cfg currently has the wrong wallpaper paths - it should be:

diff --git a/rgui/Lines.cfg b/rgui/Lines.cfg
index d5f314a2..e88b8ddf 100644
--- a/rgui/Lines.cfg
+++ b/rgui/Lines.cfg
@@ -7,6 +7,6 @@ rgui_border_dark_color = "0xFF632B6C"
 rgui_border_light_color = "0xFF632B6C"
 rgui_shadow_color = "0xFF000000"
 rgui_particle_color = "0xFF485D94"
-rgui_wallpaper = "wallpaper/gadsby_fires_.png"
-rgui_wallpaper_16_9 = "wallpaper/gadsby_lines_16_9.png"
-rgui_wallpaper_16_10 = "wallpaper/gadsby_lines_16_10.png"
+rgui_wallpaper = "wallpaper/Gadsby_Lines.png"
+rgui_wallpaper_16_9 = "wallpaper/Gadsby_Lines_16_9.png"
+rgui_wallpaper_16_10 = "wallpaper/Gadsby_Lines_16_10.png"

(On a side note, I would recommend standardising on all-lowercase wallpaper file names)

You've done a great job with the colours, but I think slight tweaks would make them even better:
- Blue.cfg: This is my favourite. The only thing I'd change here is the particle colour - at present, the animations are very hard to see. I'd probably suggest shifting them more to the greenish hue of the wallpaper highlights.
- Fires.cfg: The text is a little hard to see on this one when shadow effects are off. I'd suggest increasing the brightness of the normal and hover text. And again, the particle effects are a bit dull - you have lots of nice highlight colours in the wallpaper, so I'd probably shift towards one of them for the particles.
- Lines.cfg: Normal text and titles are again slightly difficult to read with shadows off. I think just a slight increase in brightness would really improve them. And again, the particle colours could use a bit more 'pop'.

(These are just suggestions though - feel free to ignore them!)

Anyway, as I said - it's brilliant to see more theme contributions. Thank you for your efforts!

fpscan commented 5 years ago

Hi @jdgleaver thank you for tips! Since Blue one is your fav I didn't changed :)) last 2 I had to use shadow effect, without shadow effect I couldn't catch that harsh look...

jdgleaver commented 5 years ago

Nice!

I can't see any reason not to merge this now :)

fpscan commented 5 years ago

Essential-bg this is the bg made by me

inactive123 commented 5 years ago

@jdgleaver can this be merged? Or are we still waiting on something to be fixed up here?

jdgleaver commented 5 years ago

@twinaphex It's all good as far as I'm concerned.

(Although since this now contains an XMB theme as well as RGUI themes, I don't know if anyone else wants to review the former)

fpscan commented 5 years ago

Hi,

I actually did separate pr for these but somehow ended up together. :)

4 Ağu 2019 Paz, saat 13:45 tarihinde jdgleaver notifications@github.com şunu yazdı:

@twinaphex https://github.com/twinaphex It's all good as far as I'm concerned.

(Although since this now contains an XMB theme as well as RGUI themes, I don't know if anyone else wants to review the former)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/retroarch-assets/pull/316?email_source=notifications&email_token=ABDPXKBA6NY2UF377PEGY6LQC2XK7A5CNFSM4IG6WBS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3P7CIA#issuecomment-517992736, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDPXKBSTNDJOYE32JW3MLLQC2XK7ANCNFSM4IG6WBSQ .

--

RobLoach commented 5 years ago

Splitting the PR would make it easier to review. If that's not an option, I'd be willing to check out the XMB one

fpscan commented 5 years ago

Splitting the PR would make it easier to review. If that's not an option, I'd be willing to check out the XMB one

thank you for taking your time and review XMB, I am not sure how can I split pr into two pr, meanwhile @jdgleaver kind sir, anychance you review RGUI one last time? So when Mr. Loach review over, it would be good to go or not

Thanks everyone.

RobLoach commented 5 years ago

XMB Essential feels like a mix across RetroSystem/RetroActive and MonoChrome.

essential

Essential feels like it has similar goals to the XMB FlatUI theme. May be better to consider updating the icons in FlatUI instead of adding a new theme with similar goals? May want to get @alfrix thoughts on it.

If you'd like, I could cherry-pick a new PR for you. It's more likely to be merged/approved if the PR is clean.

fpscan commented 5 years ago

XMB Essential feels like a mix across RetroSystem/RetroActive and MonoChrome.

Essential feels like it has similar goals to the XMB FlatUI theme. May be better to consider updating the icons in FlatUI instead of adding a new theme with similar goals? May want to get @alfrix thoughts on it.

If you'd like, I could cherry-pick a new PR for you. It's more likely to be merged/approved if the PR is clean.

Yeah, it has same goal as FlatUI however FlatUI is more based on Blue scheme but Essential grand rule is more-eyecandy-color with modern icons like when you get new Android phone you will get much color scheme than your old phone. What I expect with mixing with FlatUI might give us catastrophic results since FlatUI scheme si similar to; and bg is also important in here but not sure why it didn't work on your case.

I might wrong but I am open minded

jdgleaver commented 5 years ago

@fpscan Okay, I just double checked, and the RGUI wallpaper filenames are wrong - all the rgui_wallpaper* config paths need to be lower case, and the wallpaper file names need to match. At the moment we have a mishmash - for example:

rgui_wallpaper_16_9 = "wallpaper/gadsby_Blue_16_9.png"

...when the file is: Gadsby_Blue_16_9.png

The wallpapers won't load if the names don't match!

Other than that, I'm fine with merging the RGUI themes. I might personally have tweaked the text colours a little more, but this is at the level of individual artistic preference. If you're happy with them, then so am I. :)

fpscan commented 5 years ago

Hi,

How is your day so far? :) I thought I changed those but I will check when I back at home, I am at work now.

Kind regards, Omercan

7 Ağu 2019 Çar, saat 11:59 tarihinde jdgleaver notifications@github.com şunu yazdı:

@fpscan https://github.com/fpscan Okay, I just double checked, and the RGUI wallpaper filenames are wrong - all the rgui_wallpaper* config paths need to be lower case, and the wallpaper file names need to match. At the moment we have a mishmash - for example:

rgui_wallpaper_16_9 = "wallpaper/gadsby_Blue_16_9.png"

...when the file is: Gadsby_Blue_16_9.png

The wallpapers won't load if the names don't match!

Other than that, I'm fine with merging the RGUI themes. I might personally have tweaked the text colours a little more, but this is at the level of individual artistic preference. If you're happy with them, then so am I. :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libretro/retroarch-assets/pull/316?email_source=notifications&email_token=ABDPXKCNDK5CFYKVVO2J4YLQDKFGRA5CNFSM4IG6WBS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3XXB2Y#issuecomment-519008491, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDPXKGQXVS4XN3P5YNOWPTQDKFGRANCNFSM4IG6WBSQ .

-- About me http://about.me/gods Facebook http://facebook.com/aufookyew youtube.com/fpscan9 twitter http://twitter.com/#!/fpscan9 fpscan@yahoo.com

baxysquare commented 5 years ago

I agree with @RobLoach on the theme. Your system-level icons look really nice and seem like they'd fit in well with FlatUI, but with a palette swap. That combined with the fact that based on the screen shots, the theme appears to be a WIP with some Retroactive and Monochrome theme icons serving as place holders. That puts you at a fork in the road.

I'd really love to see you finish the theme with a full set of original icons (greater than or equal to the number in the reference Monochrome set) and submit it for consideration. It's definitely a long, tough road ahead. On the other hand, FlatUI has been a WIP for years and is in desperate need of artist(s) to finish it off.

fpscan commented 5 years ago

I agree with @RobLoach on the theme. Your system-level icons look really nice and seem like they'd fit in well with FlatUI, but with a palette swap. That combined with the fact that based on the screen shots, the theme appears to be a WIP with some Retroactive and Monochrome theme icons serving as place holders. That puts you at a fork in the road.

I'd really love to see you finish the theme with a full set of original icons (greater than or equal to the number in the reference Monochrome set) and submit it for consideration. It's definitely a long, tough road ahead. On the other hand, FlatUI has been a WIP for years and is in desperate need of artist(s) to finish it off.

I see your point and thank you for taking your time to review this PR. So far Essential is not going to happen. @jdgleaver I changed file names with lower cases for RGUI, is it okay now?

RobLoach commented 5 years ago

Gadsby_Lines*.png are still using capitals :wink:

fpscan commented 5 years ago

Thank you everyone for taking your time to inform me, I am going to close this one and send new PR after I am sure everything is fine for RGUI.

edit: I also deleted my fork to start fresh

libretro / retroarch-assets

RGUI/Fire&Blue&Lines & XMB/Essential Menu updates #316