search

libretro / retroarch-assets

Assets needed for RetroArch - e.g. menu drivers, etc. Also contains the official branding.
Creative Commons Attribution 4.0 International
170 stars 161 forks source link

Add Arabic, Chinese and Korean fallback font #338

Closed guoyunhe closed 4 years ago

guoyunhe commented 4 years ago

None of fonts from asses support Arabic, Chinese and Korean properly. So I made a PR to add these fallback fonts.

Then in MaterialUI, OZONE and XMB menu driver, let RetroArch use fallback fonts when these languages are set. See https://github.com/libretro/RetroArch/pull/10699

Result:

Korean fallback font: Sunflower Screenshot_20200524_171042 Screenshot_20200524_173658

Chinese fallback font: Droid Sans Fallback Screenshot_20200524_155722

Arabic fallback font: DejaVu Sans Screenshot_20200524_170956

RobLoach commented 4 years ago

Is there a license behind Droid Sans Fallback? Do we need to include the license or a readme for it?

guoyunhe commented 4 years ago

According to Wikipedia, it is Apache License. I didn't see any license files for other fonts. So maybe we don't need to include the license file but mention the copyright and license info in the README.

guoyunhe commented 4 years ago

Not yet. If this idea is liked, I can work on it soon.

NewUserHa commented 4 years ago

could it choose a beautiful font instead of just make the font working?

guoyunhe commented 4 years ago

The fonts need to FOSS licensed and supported by RetroArch. The plan is to make the font work first. Then if someone finds a better font, it can be easily replaced.

NewUserHa commented 4 years ago

Source Han Sans?

guoyunhe commented 4 years ago

Source Han Sans doesn't have a single file that covers all CJK and is supported by RetroArch.

Same as Noto CJK.

inactive123 commented 4 years ago

Hi there, what is the status of this PR? Can this be merged?

guoyunhe commented 4 years ago

I saw @RobLoach approved this PR. Maybe @twinaphex you can merge this PR. And I will make a PR for RetroArch to support CJK fallback fonts.