Add system in RetroArch

libretro / retroarch-assets

Assets needed for RetroArch - e.g. menu drivers, etc. Also contains the official branding.

Creative Commons Attribution 4.0 International

170 stars 160 forks source link

Add system in RetroArch #405

Open AlanRibas opened 3 years ago

AlanRibas commented 3 years ago

Please add the "Amstrad GX4000" system so that instead of a folder it has the picture of the video game.

RobLoach commented 2 years ago

Contributions are welcome :wink:

baxysquare commented 2 years ago

Amstrad - GX4000 and Amstrad - GX4000-content will be added to the Monochrome theme in my next pull release. The icons have been added to and Systematic, Automatic and Retroactive and partially added to Neoactive.

That said, I have no idea where the WIMP GUI is pulling its icons from. Much like on #407, we may need help from @Tatsuya79 to get it updated.

Tatsuya79 commented 2 years ago

It's using the icons from xmb/dot-art/png where icon placeholders are taken from "monochrome". Indeed that's not good in qt white theme...

I'll check if taking them from another theme can look alright.

baxysquare commented 2 years ago

@AlanRibas I believe the addition of a black border to the icons done by @Tatsuya79 in #417 addresses this issue. You may have to wait until the next time Retroarch or Lakka is updated to see the results in action. If you feel this is sufficient to close the issue, feel free to do so.

RobLoach commented 2 years ago

Just realized we were missing the whole database for it. I've set up the groundwork for it to scan from TOSEC. It'll be named Amstrad - GX4000.

baxysquare commented 2 years ago

The Automatic, FlatUX, Monochrome, Neoactive, Retroactive and Systematic themes all have the icons available for the Amstrad GX4000. Combined with the database, that should resolve the issue in the UI. I believe this issue is ready to be closed but I currently have no way to confirm it. @AlanRibas if you wouldn't mind looking into it, that would be great.