libretro / retroarch-joypad-autoconfig

RetroArch joypad autoconfig files
MIT License
288 stars 364 forks source link

Amazon Fire TV Remote.cfg has been messed up. #777

Closed robwill80 closed 3 years ago

robwill80 commented 3 years ago

Hi. There's an issue with the file at Android/Amazon Fire TV Remote.cfg. Someone edited it with the intention of swapping the OK and Back buttons, but didn't account for the option for it in Settings > Input > Menu Controls. The user then continued to experiment with the file, making the remote's actual layout senseless for menu navigation.

What's more, the user did not change the input descriptors to match the new inputs, so some of the options now have incorrect values in the RetroArch input menu.

I'd like to ask that this file be reverted back to the condition it was in before changes were made approximately two weeks ago, fixing 3 input errors. Namely,

Thanks,

markwkidd commented 3 years ago

@farmerbb do I understand correctly that you are one of the maintainers of the Amazon version of the app? Is this in your wheelhouse?

farmerbb commented 3 years ago

I contribute to the general Android portions of the codebase, not to the Fire TV-specific stuff. @fpscan do you mind looking at this?

fpscan commented 3 years ago

Yeah, it's needed to be like that, we had a talk with Amazon representative and explained why controller layout is like that but they didn't liked the way center button and back button. So we offered Wii remote type layout, I explained the layout and they also didn't liked that, they wanted Center button enter. We had to make this change...

robwill80 commented 3 years ago

Okay, you didn't say exactly how Amazon wanted those controls to be, so I'll take a guess. I assume that they want the Center button to operate as "OK," and the Back button to operate as "Back," right? If so, that's perfect... why was the config file changed?

To be clear, the Center button was "OK." The Back button was "Back." This is assuming the "Menu Swap OK and Cancel Buttons" option is turned "Off," and standard gamepads follow the Super NES layout (A on the right, B on the bottom, etc - which the port control options reference explicitly). It also follows the Wiimote example, as the A Button is the biggest button in the centre of the Wiimote, and the Start button equivalent is in the same position on Wiimote and Fire TV Remote. This is an ideal solution, on all fronts.

Right now, for RetroArch menu navigation, the Menu button is "OK," the Center button is "Back," and the Back button does nothing... that is unintuitive to say the least, And that's also not mentioning that those same controls are currently identified incorrectly in the options menu.

Amazon agreed to that?

fpscan commented 3 years ago

So I just checked and yeah, Center button work as enter and back button doesn't work as it's intended to be but I don't understand your proposition.

Do you mean that we should have separate Android build which has "Menu Swap OK and Cancel Buttons" already on just for Amazon Appstore? What I'm going to do now is just changing between FireTV remote menu button and back button.

robwill80 commented 3 years ago

The Center button works as enter for you? Ah, I see. If that "Menu Swap" option is turned "On" by default, then that's my mistake, and I apologise. No, I'm not suggesting separate builds for Amazon or Google.

I have been using a sideloaded RetroArch on Fire TV for quite a few years now, so I just assumed that option's default "favoured" a Nintendo layout over Xbox, since (like I said) the port control options do refer to the ABXY Buttons in a Super NES layout.

Switching the Menu and Back button input on the Remote would be appreciated, and I will turn on "Menu Swap" on my end. Thank you.

fpscan commented 3 years ago

So here is how it will be. REMOTE

robwill80 commented 3 years ago

Hold on - that's the layout I asked for earlier (reverting the changes made to the file). I thought you wanted the Center button to be "B," and the Back button to be "A" (i.e. "Menu Swapped")

Sorry, I'm not trying to mess you around. I just want this thing fixed, like you do.

Correction - I just read the pull request, and it's Center as "B," and Back as "A." input_a_btn_label = "Center" input_b_btn_label = "Back" will still report incorrect values, though. They need to be swapped.

fpscan commented 3 years ago

Okay, I just didn't focused the labels but I changed them now.