Closed KamiLordus closed 1 year ago
Were those working before?
Blade Runner was still working a day/two ago (100% sure) Unfortunately, I can't say about the rest. Riven and Myst - Masterpiece were last launched a month ago.
Edit: I can also add: Myst and Riven definitely work without bugs on 2.6.1.4-7 (the only older version I have and checked).
ok, it's a regression due to the latest Dreamweb fix, 5f93be7d97bcb768338e7faca9bb4768c6fb5f87 reverts that, Myst and Blade Runner should be working now. 7d6f2ced5037e43e0f245cdedb07d4e1bc9edc2d is the new fix for Dreamweb. Riven cursor looks like a separate issue.
I tested the latest version 3a132f72 Dremweb works very well Blade Runner image is back Myst Masterpice - works very well.
I'll edit the post and leave only Riven Thank you very much for the bug fix.
Cursor in riven and myst and 11th hour and starship titanic was a old bug that also existed the diablodiab core.
https://github.com/diablodiab/libretro-scummvm-backend/issues?q=is%3Aissue+myst+is%3Aclosed
not sure if the same thing. Anyway, the cause is explained in the issue linked with a patch to the problem (then).
Opps wrong link. It's: https://github.com/diablodiab/libretro-scummvm-backend/issues/3
Mmm. No i don't think it's the same anymore. The patch is already applied to libretro-os.cpp and of the games i mentioned, only riven has the problem.
@i30817 In version 2.6.1.4-7 of 02/26/2023, Riven has no cursor bug. I'm pretty sure it wasn't in later 2.7.0 git either. The bug appeared in some version 2.8.0.
@spleen1981 we go back to version 75051b55 without the Dremweb fix?
we go back to version https://github.com/libretro/scummvm/commit/75051b551db89b5a9ede3f35b75fcf49cd3483fe without the Dremweb fix?
Check the previous commit https://github.com/libretro/scummvm/commit/7d6f2ced5037e43e0f245cdedb07d4e1bc9edc2d, that's the fix. Then there is also a separate PR pending for that engine, regarding how titles are displayed. https://github.com/scummvm/scummvm/pull/4848
Blade Runner works again for me when i strip down the function splashScreen() in engines/engine.cpp to:
void splashScreen() {
g_system->showOverlay();
g_system->updateScreen();
g_system->hideOverlay();
splash = true;
}
Apologies. Did not read the comment :+1:
I'm not even sure if i should mention this, but there is a random crash on the longest journy, although it takes a long time to trigger and i'm not sure if it's not upstream too. Reloading the last save prevents it.
Apologies because i closed the command console where it happened. It mentioned a 'linear allocator' failure. I didn't get a stacktrace.
I also noticed small graphics bugs on the game although those are minor.
@i30817 Maybe try opening a separate ticket. Some time ago I tried Longest Journey and so far the graphical errors are quite disturbing (for example, a character surrounded by a rainbow of colors).
There are 4 graphical errors i noticed (of course, this is all in software renderer mode, because i'm playing the scummvm libretro core, which might affect things).
The 'linear allocator' thing i didn't manage to trigger in debug, but it usually takes a long time playing so i'm not sure if it wouldn't be possible. It's a 'tinygl' thing, a library that scummvm uses to abstract opengl 'platform specific' work.
Today I turned on Riven and noticed that the problem with the cursor disappeared. So I'm closing the ticket.
I tested both CD and DVD versions.
Riven (DVD Windows) - the cursor has a large black square
RA 1.15 Win 11 Pro