search

libretro / scummvm

ScummVM main repository
https://www.scummvm.org
GNU General Public License v3.0
4 stars 6 forks source link

Problem with closing the game #30

Closed KamiLordus closed 1 year ago

KamiLordus commented 1 year ago

I've noticed that CD versions of the Goblins 1, 2, and 3 series have a problem when trying to exit via F1 (retroarch menu) and then close game. The "close content" option doesn't close the game, it just crashes retroarch. The problem occurs on Goblins CD versions 1-3. floppy versions work fine. Other tested games also work fine.

KamiLordus commented 1 year ago

I found another game with the same problem Secret of Monkey Island (CD dos) (game ID: monkey) Floppy version it closes without a problem.

spleen1981 commented 1 year ago

fixed by 9a861391c861a1d4103df4e28444a375e885da72

KamiLordus commented 1 year ago

Fixed. Thank you very much.

KamiLordus commented 1 year ago

@spleen1981 One more thing, it's not a big deal but could you improve the closing of Beneath a Steel Sky? Both cd and floppy close with a significant delay. In the version 36e8aa19 that I checked, the closing of this game is ultra smooth.

Edit: Ehhh Beneath a Steel Sky continues to close slowly :) I thought I was able to fix it, but I just had an older version of the core. Sorry for the confusion.

spleen1981 commented 1 year ago

can't reproduce this, but should be fixed by ce2e2f353d2a9f115d00be5b8177e580f3f378ff

KamiLordus commented 1 year ago

Unfortunately, it's still the same with Beneath. Only this game closes significantly longer and I tested 60 in my collection :) In the latest update, there was another problem with scrolling the list of games in retroarch. When you close a game (Gobliins for example) the list doesn't stop at that game, it scrolls all the way to the top.

spleen1981 commented 1 year ago

what's the exact core version you are currently testing?

In the latest update, there was another problem with scrolling the list of games in retroarch.

That should not depend on the core, which cannot do any action in the frontend other than closing itself.

KamiLordus commented 1 year ago

This 41606901(master) - liberto build windows 64 archive. The previous version 2fd912be does not have a list scrolling bug.

spleen1981 commented 1 year ago
KamiLordus commented 1 year ago

I went back to version 2fd912b and there is no problem with scrolling the list. retroarch.log

spleen1981 commented 1 year ago

ok, it seems we found an undocumented way to go to the top of the frontend playlist :) should be fixed with 5873ee968885676902df2c6765f0f520680ba80e, pls check if there is any regression regarding this thread and if it has any effect on BASS issue. is the log above just launch the game/close content once? can you set the log level to DEBUG?

KamiLordus commented 1 year ago

retroarch.log with frontend and core settings lvl 0 (debug)

with version 5873ee9 the list works fine again. BASS works the same way, it turns off with a slight delay, about 3 seconds. I also tried deleting all scummvm files (including the .ini file and the entire playlist) and downloading everything again. However, it works the same. This is not a significant problem, but I wonder why only BASS turns off longer :)

edit: @spleen1981 I have two questions regarding the RA core upgrade:

  1. When launching a game from an RA playlist, the Scummvm logo sometimes appears, but this is completely random. Is there a way to add an option to permanently disable or enable this logo? (I prefer the first option). Bez tytułu

  2. The scummvm on-screen keyboard has minor graphical errors (pink pixels). This is probably due to the file system/scummvm/extra/vkeybd_default.zip is surrounded by a pink frame. Can it be fixed? 2 444

It's just a question and very minor bugs. please don't hate me :)

spleen1981 commented 1 year ago

BASS works the same way, it turns off with a slight delay

compared to 36e8aa196f9b3c64caaec29d4d6b055dcfbd11c0 reported to quit quickly, now the core unloading makes sure scummvm thread is closed properly, while before it was just quitting. I think BASS "delay" is due to the quit message "game over player one BE VIGILANT" which we don't see as we are alreading out of the video update loop at that point (but that you can see if you exit to the ScummVM GUI from within the game [ENTER] -> return to launcher). So nothing to be done here, we have to live with those 3 secs delay.

Is there a way to add an option to permanently disable or enable this logo?

No, afaik.

The scummvm on-screen keyboard has minor graphical errors (pink pixels)

That is part of "upstream" scummvm source, not specific to the core, so any issue can be submitted through the main bug tracker

KamiLordus commented 1 year ago

Thank you for the useful information.