search

libretro / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
47 stars 56 forks source link

libretro blargg filter #207

Closed stellarporter closed 5 years ago

stellarporter commented 5 years ago

fix pixel_format selection

stellarporter commented 5 years ago

Important: you must do this PR first before adding this into snes9x core. https://github.com/libretro/RetroArch/pull/8522

Problem is that Retroarch and snes9x both contain same snes_ntsc.c code. Multiple global variables and functions create grief for emscripten compiler.

  1. Retroarch + PR
  2. snes9x + PR
  3. Emscripten compiler log https://ci.appveyor.com/project/stellarporter/snes9x/builds/23311319
hhromic commented 5 years ago

Important: you must do this PR first before adding this into snes9x core. libretro/RetroArch#8522

Problem is that Retroarch and snes9x both contain same snes_ntsc.c code. Multiple global variables and functions create grief for emscripten compiler.

  1. Retroarch + PR
  2. snes9x + PR
  3. Emscripten compiler log https://ci.appveyor.com/project/stellarporter/snes9x/builds/23311319

Looks like this PR would break this core for any current RetroArch stable until a new stable with the mentioned PR is released then?

stellarporter commented 5 years ago

All compiled cores should work on previous Retroarch executables. It's building the core (emscripten platform only) that requires latest Retroarch github source code to pass.

hhromic commented 5 years ago

Ah! sorry I didn't read clearly that you meant emscripten only. That makes sense :)

stellarporter commented 5 years ago

Screwed Android again.