search

libretro / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
47 stars 57 forks source link

replaced sound channel toggle with volume percent core options #247

Closed eadmaster closed 3 years ago

eadmaster commented 3 years ago

original issue: https://github.com/snes9xgit/snes9x/issues/675

Setting the volume % to 0 disable the channels, while 100 provide full volume (default).

inactive123 commented 3 years ago

Hi @jdgleaver,

can you determine if this can be merged? Thanks in advance.

jdgleaver commented 3 years ago

Yes, this is good - and certainly much better than just disabling channels. It's also nice that we avoid additional calculations if the volume is at the default level.

I probably would have used the same bit twiddling trick as in Gambatte (https://github.com/libretro/gambatte-libretro/pull/167#issuecomment-734504046) to avoid the division, but I expect the performance difference is irrelevant in this case.