libretro / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
46 stars 55 forks source link

Fix 4:3 aspect ratio option to actually be 4:3 regardless of cropping #273

Closed realnc closed 2 years ago

realnc commented 2 years ago

Currently, the 4:3 aspect ratio core option does not work correctly. The AR is not preserved when using overscan cropping. The AR is stretched vertically with different crop values:

https://user-images.githubusercontent.com/1665903/152073956-8a2af8d6-bf13-4863-a406-ece72890311a.mp4

This PR aims to fix it by scaling the AR by the error introduced by cropping, so the image is always 4:3, regardless of cropping:

https://user-images.githubusercontent.com/1665903/152074098-e9e78678-b9bd-44b9-bd43-b6a23045b9d9.mp4